From: Pierre Habouzit <madcoder@debian.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: janitoring
Date: Wed, 22 Jul 2009 23:34:32 +0200 [thread overview]
Message-ID: <1248298475-2990-1-git-send-email-madcoder@debian.org> (raw)
[PATCH 1/3] janitor: use NULL and not 0 for pointers.
I really dislike the use of 0 when NULL is meant. This patch probably
fixes most of them. The biggest culprit is nedmalloc, but a few
remnants exist in plain git code.
[PATCH 2/3] refactor: use bitsizeof() instead of 8 * sizeof()
use a macro for CHAR_BIT * sizeof(...), I tend to find it more
readable than 8 * sizeof(...) in the code. YMMV.
[PATCH 3/3] janitor: add DIV_ROUND_UP and use it.
Just use linux/kernel.h DIV_ROUND_UP(a, b), it's way easier to read
than (a + b - 1) / (b).
PS: I don't mind if some patches don't meet large enthusiasm and are
dropped.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
next reply other threads:[~2009-07-22 21:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 21:34 Pierre Habouzit [this message]
2009-07-22 21:34 ` [PATCH 1/3] janitor: use NULL and not 0 for pointers Pierre Habouzit
2009-07-22 21:34 ` [PATCH 2/3] refactor: use bitsizeof() instead of 8 * sizeof() Pierre Habouzit
2009-07-22 21:34 ` [PATCH 3/3] janitor: add DIV_ROUND_UP and use it Pierre Habouzit
2009-07-23 5:07 ` [PATCH 2/3] refactor: use bitsizeof() instead of 8 * sizeof() Jeff King
2009-07-23 5:09 ` Junio C Hamano
2009-07-23 5:11 ` Jeff King
2009-07-23 5:15 ` Junio C Hamano
2009-07-23 6:22 ` Pierre Habouzit
2009-07-22 22:00 ` janitoring Junio C Hamano
2009-07-22 22:02 ` janitoring Pierre Habouzit
2009-07-22 22:19 ` janitoring Junio C Hamano
2009-07-22 22:29 ` janitoring Johannes Schindelin
2009-07-23 7:27 ` janitoring Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248298475-2990-1-git-send-email-madcoder@debian.org \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.