From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix chainloding + Chainloading into logical partitions
Date: Wed, 22 Jul 2009 20:04:35 -0400 [thread overview]
Message-ID: <1248307475.2369.5.camel@ct> (raw)
In-Reply-To: <d7ead6de0907221518p7a735eb1kd9f44ab694e8f58c@mail.gmail.com>
On Thu, 2009-07-23 at 00:18 +0200, Vladimir 'phcoder' Serbinenko wrote:
> There is strictly no need to do this restructuration. The real bug is
> different fix would be setting dev->disk->partition to 0 before
> calling grub_disk_read and restoring it afterwards. This part of code
> is changed anyway with my nested partition patch and I was hoping it
> could be applied quickly. Could you test nestpart branch of my
> repository?
I'm not comfortable to approve a 60k long patch that reorganizes the
code and fixed numerous bugs in the same time. I'm sure bugs can be
fixed separately.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-23 0:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d013d84b0907221500h690d263g4cd1b9949c53c4b8@mail.gmail.com>
2009-07-22 22:11 ` [PATCH] Fix chainloding + Chainloading into logical partitions Jean-Pierre Flori
2009-07-22 22:18 ` Vladimir 'phcoder' Serbinenko
2009-07-23 0:04 ` Pavel Roskin [this message]
2009-07-23 7:59 ` Vladimir 'phcoder' Serbinenko
2009-07-24 15:04 ` Gregg C Levine
2009-07-23 12:05 ` Jean-Pierre Flori
2008-06-30 2:28 Lucas Gadani
2008-06-30 19:56 ` Fulvio Scapin
2008-07-06 18:41 ` Robert Millan
2008-07-06 20:47 ` Lucas Gadani
2008-07-10 14:08 ` Lucas Gadani
2008-07-10 15:28 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248307475.2369.5.camel@ct \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.