All of lore.kernel.org
 help / color / mirror / Atom feed
From: Constantine Plotnikov <constantine.plotnikov@gmail.com>
To: git@vger.kernel.org
Cc: Constantine Plotnikov <constantine.plotnikov@gmail.com>
Subject: [JGIT PATCH] Fixed Windows compatiblity bug in T0003_Basic.test027_UnpackedRefHigherPriorityThanPacked
Date: Thu, 23 Jul 2009 15:38:46 +0400	[thread overview]
Message-ID: <1248349126-3192-1-git-send-email-constantine.plotnikov@gmail.com> (raw)

On Windows println outputs "\r\n" sequence, so test fails since '\r' is
assumed to be a part of reference. This patch fixes test by printing '\n'
explictly instead of using system line separtory through println.

Signed-off-by: Constantine Plotnikov <constantine.plotnikov@gmail.com>
---
 .../tst/org/spearce/jgit/lib/T0003_Basic.java      |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0003_Basic.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0003_Basic.java
index b9e8d1d..df55b4f 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0003_Basic.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/T0003_Basic.java
@@ -507,7 +507,8 @@ assertEquals(ObjectId.fromString("00b1f73724f493096d1ffa0b0f1f1482dbb8c936"),
 	public void test027_UnpackedRefHigherPriorityThanPacked() throws IOException {
 		PrintWriter writer = new PrintWriter(new FileWriter(new File(db.getDirectory(), "refs/heads/a"))); 
 		String unpackedId = "7f822839a2fe9760f386cbbbcb3f92c5fe81def7";
-		writer.println(unpackedId);
+		writer.print(unpackedId);
+		writer.print('\n');
 		writer.close();
 
 		ObjectId resolved = db.resolve("refs/heads/a");
-- 
1.6.1.2

                 reply	other threads:[~2009-07-23 11:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248349126-3192-1-git-send-email-constantine.plotnikov@gmail.com \
    --to=constantine.plotnikov@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.