From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MTzQU-0006Fl-St for mharc-grub-devel@gnu.org; Thu, 23 Jul 2009 10:37:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTzQT-0006Bk-5B for grub-devel@gnu.org; Thu, 23 Jul 2009 10:37:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTzQO-00060z-E6 for grub-devel@gnu.org; Thu, 23 Jul 2009 10:37:40 -0400 Received: from [199.232.76.173] (port=50313 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTzQO-00060i-9t for grub-devel@gnu.org; Thu, 23 Jul 2009 10:37:36 -0400 Received: from mx20.gnu.org ([199.232.41.8]:48797) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTzQN-0002Ed-PQ for grub-devel@gnu.org; Thu, 23 Jul 2009 10:37:36 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTzQM-0000rp-Fq for grub-devel@gnu.org; Thu, 23 Jul 2009 10:37:34 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 23 Jul 2009 10:37:33 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 1BF7334C6A for ; Thu, 23 Jul 2009 10:48:14 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1248347411.4660.81.camel@accesodirecto.casa> References: <1248347411.4660.81.camel@accesodirecto.casa> Content-Type: text/plain; charset="ISO-8859-1" Date: Thu, 23 Jul 2009 10:37:31 -0400 Message-Id: <1248359851.7855.2.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 8bit X-Detected-Operating-System: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] Check for the appropriate condition in types.h X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2009 14:37:41 -0000 On Thu, 2009-07-23 at 13:10 +0200, Javier Martín wrote: > Currently verifies that sizeof(void*)==sizeof(long) and > then proceeds to define most fixed-length types based on sizeof(void*). > While simplification seems a good idea on paper, it is always good > practice to check specifically for what we want to know. In particular, > the assumption that long can hold a pointer will go down when (if) > mingw64 support is merged, because Win64 follows the LLP64 model instead > of the LP64 *nix model. > > Given that currently both values are, by precondition, the same, this > change is guaranteed not to create any problems, while it might avoid > them in the future. The patch is good. Please include the ChangeLog entry. -- Regards, Pavel Roskin