From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MU4xi-0003oe-Cj for mharc-grub-devel@gnu.org; Thu, 23 Jul 2009 16:32:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MU4xg-0003nq-9q for grub-devel@gnu.org; Thu, 23 Jul 2009 16:32:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MU4xb-0003l5-76 for grub-devel@gnu.org; Thu, 23 Jul 2009 16:32:19 -0400 Received: from [199.232.76.173] (port=42926 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MU4xb-0003kz-0W for grub-devel@gnu.org; Thu, 23 Jul 2009 16:32:15 -0400 Received: from c60.cesmail.net ([216.154.195.49]:26408) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MU4xa-0003N9-1U for grub-devel@gnu.org; Thu, 23 Jul 2009 16:32:14 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 23 Jul 2009 16:32:10 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id A5DE634C88 for ; Thu, 23 Jul 2009 16:42:53 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Thu, 23 Jul 2009 16:32:09 -0400 Message-Id: <1248381129.2661.79.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH 2/2] SDL support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2009 20:32:20 -0000 On Thu, 2009-07-23 at 11:49 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. Here is already-discussed SDL support The patch refers to video/fb/video_fb.c, which is not included. Also, please check the changes I made to your changes to configure.ac. Please check the spelling of "explicitly". There is no need for verbose excuses, it's enough to say "need SDL library" or "need SDL headers". "build and install the `grub-emu' debugging utility with SDL support" is also too long and not quite correct. --enable-grub-emu-sdl decides whether SDL support will be in grub-emu. Since it's the default, maybe it's better to describe --disable-grub-emu-sdl. Obviously, it applies to grub-emu-usb as well, I just didn't have a chance to clean it up. -- Regards, Pavel Roskin