From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MU7uz-0003zK-Rl for mharc-grub-devel@gnu.org; Thu, 23 Jul 2009 19:41:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MU7ux-0003zA-VD for grub-devel@gnu.org; Thu, 23 Jul 2009 19:41:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MU7ut-0003xp-KF for grub-devel@gnu.org; Thu, 23 Jul 2009 19:41:43 -0400 Received: from [199.232.76.173] (port=39976 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MU7ut-0003xl-F3 for grub-devel@gnu.org; Thu, 23 Jul 2009 19:41:39 -0400 Received: from c60.cesmail.net ([216.154.195.49]:55666) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MU7us-0006G8-LT for grub-devel@gnu.org; Thu, 23 Jul 2009 19:41:38 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 23 Jul 2009 19:41:36 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 0379234C6A for ; Thu, 23 Jul 2009 19:52:20 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Thu, 23 Jul 2009 19:41:35 -0400 Message-Id: <1248392495.2661.208.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Fwd: [PATCH 1/2] Framebuffer split X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2009 23:41:44 -0000 On Thu, 2009-07-23 at 11:52 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. Here is a framebuffer split which has already been discussed. > This patch contains some code by Collin D Bennett in addition to my > code. Sorry for compression but maillist server doesn't accept it otherwise Please include an uncompressed ChangeLog entry. Even though the issue was discussed, it would help if you include a description of the changes to simplify reviewing. You can copy a previously posted description. grub_video_vbe_set_viewport and grub_video_vbe_get_info_and_fini need to be declared static to avoid compiler warnings. Apart from that, no warnings are introduced. Please don't add trailing whitespace. Since you are using git, you can easily check it with STGit by running "stg edit -d". grub_video_vbe_get_info_and_fini strikes as a weird name. The comment says: /* Get information about active video mode. */ Likewise, all occurrences of "get_info_and_fini" should probably be replaced with something more descriptive. -- Regards, Pavel Roskin