From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MUR4s-0004EU-IY for mharc-grub-devel@gnu.org; Fri, 24 Jul 2009 16:09:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUR4r-0004CP-84 for grub-devel@gnu.org; Fri, 24 Jul 2009 16:09:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUR4m-00047u-Fk for grub-devel@gnu.org; Fri, 24 Jul 2009 16:09:12 -0400 Received: from [199.232.76.173] (port=44318 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUR4m-00047Y-6y for grub-devel@gnu.org; Fri, 24 Jul 2009 16:09:08 -0400 Received: from c60.cesmail.net ([216.154.195.49]:51606) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MUR4l-0001PC-IL for grub-devel@gnu.org; Fri, 24 Jul 2009 16:09:07 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 24 Jul 2009 16:09:06 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 1800B34C6D for ; Fri, 24 Jul 2009 16:19:57 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1248461206.3510.76.camel@fz.local> References: <1248461206.3510.76.camel@fz.local> Content-Type: text/plain Date: Fri, 24 Jul 2009 16:09:04 -0400 Message-Id: <1248466144.6620.16.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults] X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2009 20:09:13 -0000 On Fri, 2009-07-24 at 20:46 +0200, Felix Zielcke wrote: > And another bug forward > Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcmp > here: > grub_partition_iterate (dest_dev->disk, (strcmp (dest_partmap, "pc_partition_map") ? > find_usable_region_gpt : find_usable_region_msdos)); dest_partmap is only assigned a value in identify_partmap. If grub_partition_iterate() doesn't find any partitions, dest_partmap remains a random pointer. The fix would be probably to initialize dest_partmap with NULL. If it becomes "pc_partition_map", iterate with find_usable_region_msdos, if it becomes "gpt_partition_map", iterate with find_usable_region_gpt. If it's NULL or another string, exit with a warning. -- Regards, Pavel Roskin