From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MURvp-00047U-Tl for mharc-grub-devel@gnu.org; Fri, 24 Jul 2009 17:03:57 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MURvn-00043f-7y for grub-devel@gnu.org; Fri, 24 Jul 2009 17:03:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MURvi-0003wO-AG for grub-devel@gnu.org; Fri, 24 Jul 2009 17:03:54 -0400 Received: from [199.232.76.173] (port=34614 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MURvh-0003w6-VY for grub-devel@gnu.org; Fri, 24 Jul 2009 17:03:50 -0400 Received: from c60.cesmail.net ([216.154.195.49]:13007) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MURvh-0008Dl-6d for grub-devel@gnu.org; Fri, 24 Jul 2009 17:03:49 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 24 Jul 2009 17:03:47 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 56D5E34C6D for ; Fri, 24 Jul 2009 17:14:39 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <1248454704.3510.67.camel@fz.local> <1248465392.6620.10.camel@mj> Content-Type: text/plain Date: Fri, 24 Jul 2009 17:03:45 -0400 Message-Id: <1248469425.6620.29.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix an infinite loop with a corrupted pc partition table X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2009 21:03:55 -0000 On Fri, 2009-07-24 at 22:35 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello > >> This patch fixes it, but probable there's a better fix. > > > > We could require that all references to extended partitions are only > > considered if they lead to a sector after the one currently being > > processed. > I already thought about this and spoke about it on IRC. Unfortunately > backward pointers do exist. I had it few years ago when I used > diskdrake. It put the logical partition at the end of the chain even > if partition itself was in the middle of the disk. I don't know if it > still has this behaviour but partition schemes have sometimes tendency > to stay a long time. I don't like they idea of user not being able to > boot his mandriva or some partitions not being accessible. This would still work. This is still allowed: MBR ----------------> Ext Logical <-----/ This is what I want to forbid: MBR ----------------> Ext Ext <----/ \--------------> Logical I don't think any tool would create that insanity. > A big problem with pc partitions is that AFAIK there is no normative > standard for it, only descriptive documents Yes, it's a typical "industry standard" :-( -- Regards, Pavel Roskin