From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MUb5r-0003ns-IU for mharc-grub-devel@gnu.org; Sat, 25 Jul 2009 02:50:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUb5q-0003nn-1k for grub-devel@gnu.org; Sat, 25 Jul 2009 02:50:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUb5k-0003ma-Ox for grub-devel@gnu.org; Sat, 25 Jul 2009 02:50:53 -0400 Received: from [199.232.76.173] (port=45487 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUb5k-0003mO-Iy for grub-devel@gnu.org; Sat, 25 Jul 2009 02:50:48 -0400 Received: from mx20.gnu.org ([199.232.41.8]:47789) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MUb5k-0002UD-2e for grub-devel@gnu.org; Sat, 25 Jul 2009 02:50:48 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MUb5j-0008QQ-9k for grub-devel@gnu.org; Sat, 25 Jul 2009 02:50:47 -0400 Received: from [85.180.56.217] (e180056217.adsl.alicedsl.de [85.180.56.217]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MKt2u-1MUb5g0FUP-000BcC; Sat, 25 Jul 2009 08:50:44 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: References: <1248461206.3510.76.camel@fz.local> <1248466144.6620.16.camel@mj> Content-Type: text/plain Date: Sat, 25 Jul 2009 08:51:32 +0200 Message-Id: <1248504692.3665.3.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.4 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/2+2u4tLdxaEkjYndbFNJzLvyi0UakTFIfRz0 GQLF2QEhmmyi6OAw7I4gv2qSrMbJJN34ZZgYMpwEOHLXbxmrJC LSnhhMq0ZLOVWzLVXucYXM7eugB0Ugk X-Detected-Operating-System: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults] X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2009 06:50:54 -0000 Am Freitag, den 24.07.2009, 22:37 +0200 schrieb Vladimir 'phcoder' Serbinenko: > On Fri, Jul 24, 2009 at 10:09 PM, Pavel Roskin wrote: > > On Fri, 2009-07-24 at 20:46 +0200, Felix Zielcke wrote: > >> And another bug forward > >> Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcmp > >> here: > >> grub_partition_iterate (dest_dev->disk, (strcmp (dest_partmap, "pc_partition_map") ? > >> find_usable_region_gpt : find_usable_region_msdos)); > > > > dest_partmap is only assigned a value in identify_partmap. If > > grub_partition_iterate() doesn't find any partitions, dest_partmap > > remains a random pointer. > > > > The fix would be probably to initialize dest_partmap with NULL. If it > > becomes "pc_partition_map", iterate with find_usable_region_msdos, if it > > becomes "gpt_partition_map", iterate with find_usable_region_gpt. If > > it's NULL or another string, exit with a warning. > Actualy I already fixed this in my patch for installing on > partitionless devices. Since there were no oppositions I'll commit it Thanks, it fixed the segfault for Jean-Luc. -- Felix Zielcke Proud Debian Maintainer