From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MUdar-0005uM-8V for mharc-grub-devel@gnu.org; Sat, 25 Jul 2009 05:31:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUdao-0005u1-Pf for grub-devel@gnu.org; Sat, 25 Jul 2009 05:31:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUdak-0005tU-6e for grub-devel@gnu.org; Sat, 25 Jul 2009 05:31:02 -0400 Received: from [199.232.76.173] (port=46855 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUdaj-0005tR-Vi for grub-devel@gnu.org; Sat, 25 Jul 2009 05:30:58 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:50444) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MUdaj-0006Zd-Dt for grub-devel@gnu.org; Sat, 25 Jul 2009 05:30:57 -0400 Received: from [85.180.56.217] (e180056217.adsl.alicedsl.de [85.180.56.217]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MKt2u-1MUdai1txB-000BE3; Sat, 25 Jul 2009 11:30:56 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: References: <1248478502.3510.96.camel@fz.local> Content-Type: text/plain Date: Sat, 25 Jul 2009 11:31:44 +0200 Message-Id: <1248514304.3665.10.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.4 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/zEZ7yWgRpxBevPXBG+5GqlyqpwwVm+G57P0C psimFsF7pDOdBKL3MV2PLmcPFHcpsVjhWiLZXSk28V741b2siF 49mp63HUUXfXnm7MfKqtEzLrlL3Oo3W X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [Fwd: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1] X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2009 09:31:03 -0000 Am Samstag, den 25.07.2009, 10:37 +0200 schrieb Vladimir 'phcoder' Serbinenko: > On Sat, Jul 25, 2009 at 1:35 AM, Felix Zielcke wrote: > > Is this an acceptable fix? > > Though I have the feeling this isn't a proper one. > > > >> > >> The fix is to assign grub_errno before making the call to > >> grub_file_get_device_name(): > Just check whether returned device_name is 0 or not Ok, I should have checked the actual code. That was pretty clear. Sorry for the noise. > >> > >> diff --git a/kern/file.c b/kern/file.c > >> index adf55da..5e605f9 100644 > >> --- a/kern/file.c > >> +++ b/kern/file.c > >> @@ -59,6 +59,7 @@ grub_file_open (const char *name) > >> char *device_name; > >> char *file_name; > >> > >> + grub_errno = GRUB_ERR_NONE; /* Used as error flag */ > >> device_name = grub_file_get_device_name (name); > >> if (grub_errno) > >> return 0; > > > > > > -- > > Felix Zielcke > > Proud Debian Maintainer > > > > > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > http://lists.gnu.org/mailman/listinfo/grub-devel > > > > > -- Felix Zielcke Proud Debian Maintainer