From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabian Deutsch Subject: Re: Regarding 2a5e626aa6e08d894e74af053236947cced8ff87 Date: Sat, 25 Jul 2009 11:53:19 +0200 Message-ID: <1248515599.4587.1.camel@decade.local> References: <1248353811.4605.9.camel@decade.local> <4A689245.5000204@garzik.org> <1248370729.7812.1.camel@localhost.localdomain> <4A68A7A3.4050606@garzik.org> <1248443457.2444.13.camel@localhost.localdomain> <4A6A6747.8020007@garzik.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A6A6747.8020007@garzik.org> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Jeff Garzik Cc: hail-devel@vger.kernel.org Am Freitag, den 24.07.2009, 22:00 -0400 schrieb Jeff Garzik: > Fabian Deutsch wrote: > > Am Donnerstag, den 23.07.2009, 14:10 -0400 schrieb Jeff Garzik: > >> Fabian Deutsch wrote: > >>>>> Regarding the aboved mentioned commit, I'd suggest using > >>>>> > >>>>> #define CLD_DEF_DATADIR "/tmp/cld/lib" > >>>>> > >>>>> instead of > >>>>> > >>>>> #define CLD_DEF_DATADIR "/spare/tmp/cld/lib" > >>>>> > >>>>> as /tmp seems to be more present than /spare. > >>>> True, though ideally someone should go through Fedora and autotools, and > >>>> figure out the proper location -- most likely somewhere in /var. You > >>>> never want permanent data in /tmp, either. :) > >>> Yeah, reboots might have surprising effects :) > >>> Maybe something like the attached patch: Using autools vars to determin > >>> some paths .. > >> Your patch is heading in the right direction, but I have a few comments... > >> > >> * IIRC, AC_DEFINE() macro in configure.ac is the right place to define > >> this sort of thing > > > > I've followed the recommended way mentioned here: > > http://www.gnu.org/software/autoconf/manual/html_node/Installation-Directory-Variables.html#Installation-Directory-Variables > > > > AC_DEFINE shall not be used per se ... > > Well, I disagree [with GNU], but it's a standard, so we'll go this way... So, you two pence, why AC_DEFINE would be a betterw ay? - fabian