From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MUkZO-0008WK-6j for mharc-grub-devel@gnu.org; Sat, 25 Jul 2009 12:58:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUkZL-0008VO-Rj for grub-devel@gnu.org; Sat, 25 Jul 2009 12:57:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUkZH-0008UV-FC for grub-devel@gnu.org; Sat, 25 Jul 2009 12:57:59 -0400 Received: from [199.232.76.173] (port=38885 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUkZH-0008US-Ce for grub-devel@gnu.org; Sat, 25 Jul 2009 12:57:55 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:60749) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MUkZF-00032S-Vm for grub-devel@gnu.org; Sat, 25 Jul 2009 12:57:55 -0400 Received: from [85.180.46.60] (e180046060.adsl.alicedsl.de [85.180.46.60]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0MKt72-1MUkZE2fAB-000A65; Sat, 25 Jul 2009 18:57:53 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090725164504.GP12326@thorin> References: <1248478502.3510.96.camel@fz.local> <20090725164504.GP12326@thorin> Content-Type: text/plain Date: Sat, 25 Jul 2009 18:58:41 +0200 Message-Id: <1248541121.3667.10.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.4 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1//7dNnNLqQI/JPHemr9sM9X8/E645ArM1ozRE 5YVnEhc4Eyu7yQNjWP3OTArgHXfzStaW9poOfqoOqS00H2hTc0 9f6axLYjVPgGRL0u6uMS3n6jUkIkID1 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [Fwd: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1] X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2009 16:58:00 -0000 Am Samstag, den 25.07.2009, 18:45 +0200 schrieb Robert Millan: > On Sat, Jul 25, 2009 at 01:35:02AM +0200, Felix Zielcke wrote: > > Is this an acceptable fix? > > Though I have the feeling this isn't a proper one. > > > > -------- Weitergeleitete Nachricht -------- > > > Von: Bob Gilligan > > > Reply-to: Bob Gilligan , 503344@bugs.debian.org > > > An: submit@bugs.debian.org > > > Betreff: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1 > > > Datum: Fri, 24 Oct 2008 16:19:59 -0700 > > > > > > Package: grub-pc > > > Version: 1.96+20080724-10 > > > > > > After installing grub-pc on an IBM x3250 with two 160 GB drives, with > > > the root filesystem configured using mdadm for RAID-1, grub fails to > > > boot, printing: > > > > > > Welcome to GRUB! > > > > > > error: unknown device fd1 > > > Entering rescue mode ... > > > grub rescue> > > ISTR we disabled floppy support completely in debian in order to avoid this > kind of trouble (I would disable it in official GRUB as well, but I can > already feel there'd be some opposition :-)). Only for util/hostdisk.c > Anyway, my point is that floppies are too unreliable. We detect them when > iterating even if they're not readable. Perhaps we could actually probe them > for read during iteration to solve this. > > > > + grub_errno = GRUB_ERR_NONE; /* Used as error flag */ > > > device_name = grub_file_get_device_name (name); > > > if (grub_errno) > > > return 0; > > This looks like a hack. > r2444 should fix this. I just check now if it returns 0 and not for grub_errno. -- Felix Zielcke Proud Debian Maintainer