From: Arnaud Faucher <arnaud.faucher@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org,
Carlos Corbacho <carlos@strangeworlds.co.uk>
Subject: Re: [PATCH 1/1] acer-wmi: switch driver to dev_pm_ops
Date: Sat, 25 Jul 2009 16:10:30 -0400 [thread overview]
Message-ID: <1248552630.20372.21.camel@green> (raw)
In-Reply-To: <20090725174311.GB14062@dtor-d630.eng.vmware.com>
On Sat, 2009-07-25 at 10:43 -0700, Dmitry Torokhov wrote:
> Hi Arnaud,
>
> On Sat, Jul 25, 2009 at 09:04:51AM -0400, Arnaud Faucher wrote:
> > Gets rid of the following warning:
> > Platform driver 'acer-wmi' needs updating - please use dev_pm_ops
> >
>
> Have you tested it with Suspend to disk? You are [potentially] breaking
> it since the new suspend and resume methods are not used by it, it calls
> freeze() and thaw() instead.
>
> Rafael,
>
> I wonder if PM core should automatically use suspend()/resume() in place of
> freeze()/thaw() when the latter pair is missing.
>
By studying drivers/base/platform.c, suspend()/resume() are not called
when freeze()/thaw() are missing. So you're right, this patch breaks
something.
I am testing right now a new patch against hibernation.
prev parent reply other threads:[~2009-07-25 20:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 13:04 [PATCH 1/1] acer-wmi: switch driver to dev_pm_ops Arnaud Faucher
2009-07-25 17:43 ` Dmitry Torokhov
2009-07-25 20:04 ` Rafael J. Wysocki
2009-07-26 13:53 ` Arnaud Faucher
2009-07-26 14:23 ` Carlos Corbacho
2009-07-26 18:08 ` Dmitry Torokhov
2009-07-26 18:35 ` Carlos Corbacho
2009-07-26 20:28 ` Arnaud Faucher
2009-07-26 21:33 ` Dmitry Torokhov
2009-07-26 22:51 ` Arnaud Faucher
2009-07-28 23:39 ` Arnaud Faucher
2009-07-29 20:49 ` Rafael J. Wysocki
2009-07-29 21:03 ` Dmitry Torokhov
2009-07-29 22:53 ` Arnaud Faucher
2009-07-30 22:05 ` Arnaud Faucher
2009-07-31 11:56 ` Rafael J. Wysocki
2009-07-29 23:27 ` Rafael J. Wysocki
2009-07-25 20:04 ` Rafael J. Wysocki
2009-07-25 20:10 ` Arnaud Faucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248552630.20372.21.camel@green \
--to=arnaud.faucher@gmail.com \
--cc=carlos@strangeworlds.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.