From: Eric Paris <eparis@redhat.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Scott James Remnant <scott@ubuntu.com>, linux-kernel@vger.kernel.org
Subject: Re: inotify regression, missing events
Date: Sat, 25 Jul 2009 18:27:40 -0400 [thread overview]
Message-ID: <1248560860.3567.135.camel@localhost> (raw)
In-Reply-To: <200907260023.36398.rjw@sisk.pl>
On Sun, 2009-07-26 at 00:23 +0200, Rafael J. Wysocki wrote:
> On Monday 13 July 2009, Eric Paris wrote:
> > On Mon, 2009-07-13 at 13:21 +0100, Scott James Remnant wrote:
> > > On Sat, 2009-07-11 at 07:50 -0400, Eric Paris wrote:
> > >
> > > > On Sat, 2009-07-11 at 17:02 +0100, Scott James Remnant wrote:
> > > > > Looks like there's a regression with inotify since the rewrite to use
> > > > > fanotify. Events are simply missing and not being delivered to
> > > > > userspace.
> > > > >
> > > > > Here's a simple test case, just compile and run it:
> > > >
> > > > I bet I know exactly what it is (notification.c tail merge code isn't
> > > > comparing filename only inode+mask) but I'm walking out of the house.
> > > > I'll try my theory later tonight and post a patch.
> > > >
> > > > Stupid Eric, Stupid.
> > > >
> > > In other words, when the second deleted-file-in-a-directory event comes
> > > through, it gets ignored because there's already a
> > > "deleted-file-in-a-directory" event for that directory?
> >
> > Yes, and I sent a patch but apparent screwed up the --smtp-server option
> > so it never got out. Resending. Sorry.....
>
> Did the patch reach Linus eventually?
No, I sent a git-pull but Linus did not pull from my tree before -rc4.
If he doesn't do it in his openning -rc5 salvo I'll send the request
again.
-Eric
prev parent reply other threads:[~2009-07-25 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 16:02 inotify regression, missing events Scott James Remnant
2009-07-11 11:50 ` Eric Paris
2009-07-13 12:21 ` Scott James Remnant
2009-07-13 13:43 ` Eric Paris
2009-07-25 22:23 ` Rafael J. Wysocki
2009-07-25 22:27 ` Eric Paris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248560860.3567.135.camel@localhost \
--to=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=scott@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.