From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Sun, 26 Jul 2009 22:11:07 +0000 Subject: Re: [GIT PULL] Add KVM support for Book3s_64 (PPC64) hosts v3 Message-Id: <1248646267.28464.12.camel@pasglop> List-Id: References: <1248453028-49627-1-git-send-email-agraf@suse.de> In-Reply-To: <1248453028-49627-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Sun, 2009-07-26 at 22:47 +0200, Alexander Graf wrote: > When we just interpret the bitmap as u64* do we break 32 on 64 x86? If > not, that makes it work for 32 on 64 ppc, because the kernel is always > 64. It just a matter of having the bits in the right place. The kernel will not always be 64-bit though, for example it's no for kvm/e500 or kvm/440 and there's no reason those could get gfx at some stage. Now, the kernel -does- provide _le variants of the bitops, and those have the side advantage of being agnostic to 32 vs. 64 bit so maybe that what we should use everywhere ? Look at ppc's bitops.h, it has nice descriptions of the format. Cheers, Ben.