From: Daniel Walker <dwalker@fifo99.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [Patch RFC 23/37] usb: gadgetfs: Convert semaphore to mutex
Date: Sun, 26 Jul 2009 15:56:39 -0700 [thread overview]
Message-ID: <1248648999.28841.6.camel@desktop> (raw)
In-Reply-To: <20090726081556.264284945@linutronix.de>
On Sun, 2009-07-26 at 08:18 +0000, Thomas Gleixner wrote:
> - if (down_trylock (&epdata->lock) != 0)
> + if (mutex_trylock(&epdata->lock) != 0)
You forget the mutex_trylock has an inverted return value..
Daniel
next prev parent reply other threads:[~2009-07-26 22:56 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-26 8:17 [Patch RFC 00/37] Cleanup init_MUTEX[_LOCKED] / DECLARE_MUTEX Thomas Gleixner
2009-07-26 8:17 ` [Patch RFC 01/37] semaphore: Add DEFINE_SEMAPHORE, semaphore_init, semaphore_init_locked Thomas Gleixner
2009-07-26 23:04 ` Daniel Walker
2009-07-27 15:25 ` Christoph Hellwig
2009-07-27 15:32 ` Thomas Gleixner
2009-07-27 15:24 ` Christoph Hellwig
2009-07-26 8:17 ` [Patch RFC 02/37] input: keyboard/hil_kbd: semaphore cleanup Thomas Gleixner
2009-07-28 7:36 ` Dmitry Torokhov
2009-07-26 8:17 ` [Patch RFC 03/37] input: misc/hp_sdc_rtc: " Thomas Gleixner
2009-07-26 8:17 ` [Patch RFC 04/37] input: mouse/hil_ptr: " Thomas Gleixner
2009-07-26 8:17 ` [Patch RFC 05/37] input: serio/hil_mlc: " Thomas Gleixner
2009-07-26 8:17 ` [Patch RFC 06/37] input: serio/hp_sdc: " Thomas Gleixner
2009-07-26 8:17 ` [Patch RFC 07/37] net: 3c527: " Thomas Gleixner
2009-07-26 8:17 ` [Patch RFC 08/37] hamradio: 6pack: " Thomas Gleixner
2009-07-26 8:17 ` [Patch RFC 09/37] hamradio: mkiss: " Thomas Gleixner
2009-07-26 8:17 ` [Patch RFC 10/37] net: ppp_async: " Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 11/37] parport: " Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 12/37] ibmphp-hpc: " Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 13/37] s390: cio/crw: " Thomas Gleixner
2009-07-27 11:45 ` Martin Schwidefsky
2009-07-26 8:18 ` [Patch RFC 14/37] scsi: aacraid " Thomas Gleixner
2009-07-26 20:11 ` James Bottomley
2009-07-26 22:21 ` Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 15/37] bluetooth: Convert hdev->req_lock to mutex Thomas Gleixner
2009-07-26 21:36 ` Marcel Holtmann
2009-07-26 22:04 ` Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 16/37] smbfs: Convert server->sem " Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 17/37] hpfs: Convert sbi->hpfs_creation_de " Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 18/37] hpfsplus: Convert tree_lock " Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 19/37] hfs: " Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 20/37] cifs: convert semaphore " Thomas Gleixner
2009-07-27 1:14 ` Jeff Layton
2009-07-30 21:09 ` Christoph Hellwig
2009-07-30 22:43 ` Steven French
2009-07-26 8:18 ` [Patch RFC 21/37] affs: use semaphore_init instead of init_MUTEX Thomas Gleixner
2009-07-30 21:14 ` Christoph Hellwig
2009-07-26 8:18 ` [Patch RFC 22/37] usb: ftdi-elan: Convert "mutex" to semaphore Thomas Gleixner
2009-07-26 8:18 ` [Patch RFC 23/37] usb: gadgetfs: Convert semaphore to mutex Thomas Gleixner
2009-07-26 22:56 ` Daniel Walker [this message]
2009-07-26 8:19 ` [Patch RFC 24/37] xfs: semaphore cleanup Thomas Gleixner
2009-07-27 15:25 ` Christoph Hellwig
2009-07-26 8:19 ` [Patch RFC 25/37] net: wan/cosa.c: Convert "mutex" to semaphore Thomas Gleixner
2009-07-26 8:19 ` [Patch RFC 26/37] irda: semaphore cleanup Thomas Gleixner
2009-07-26 8:19 ` [Patch RFC 27/37] mmc: Convert "mutex" to semaphore Thomas Gleixner
2009-07-26 8:19 ` [Patch RFC 28/37] dvb: " Thomas Gleixner
2009-07-26 8:19 ` [Patch RFC 29/37] infiniband: Make user_mad semaphore a real one Thomas Gleixner
2009-07-27 16:26 ` Roland Dreier
2009-07-27 16:28 ` Thomas Gleixner
2009-07-26 8:19 ` [Patch RFC 30/37] drivers/base: Convert dev->sem to mutex Thomas Gleixner
2009-07-26 8:19 ` [Patch RFC 31/37] ia64: salinfo: semaphore_init instead of init_MUTEX Thomas Gleixner
2009-07-26 8:19 ` [Patch RFC 32/37] drivers/macintosh/adb: Do not claim that the semaphore is a mutex Thomas Gleixner
2009-07-26 8:20 ` [Patch RFC 33/37] arm: w90x900: convert semaphore to mutex Thomas Gleixner
2009-07-27 3:11 ` Wan ZongShun
2009-07-26 8:20 ` [Patch RFC 34/37] printk: Make console_sem a semaphore not a pseudo mutex Thomas Gleixner
2009-07-26 8:20 ` [Patch RFC 35/37] staging: Bulk convert the semaphore mess Thomas Gleixner
2009-07-26 8:20 ` [Patch RFC 36/37] fs: Convert bd_mount_sem to mutex Thomas Gleixner
2009-07-27 15:26 ` Christoph Hellwig
2009-07-27 15:30 ` Thomas Gleixner
2009-07-27 16:42 ` Daniel Walker
2009-07-26 8:20 ` [Patch RFC 37/37] semaphore: Remove mutex emulation Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248648999.28841.6.camel@desktop \
--to=dwalker@fifo99.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.