All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Benjamin Krill <ben@codiert.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] prom_init: evaluate mem kernel parameter for early allocation
Date: Mon, 27 Jul 2009 14:09:37 +1000	[thread overview]
Message-ID: <1248667777.5706.0.camel@pasglop> (raw)
In-Reply-To: <20090717202922.GA20168@codiert.org>

On Fri, 2009-07-17 at 22:29 +0200, Benjamin Krill wrote:
> Evaluate mem kernel parameter for early memory allocations. If mem is set
> no allocation in the region above the given boundary is allowed. The current
> code doesn't take care about this and allocate memory above the given mem
> boundary.

Breaks build on ppc32 due to ...

> +	opt = strstr(RELOC(prom_cmd_line), RELOC("mem="));

"opt" isn't defined (it's defined inside CONFIG_PPC64). Please respin
a patch that also removes that bit so that "opt" is always defined.

Cheers,
Ben.

      reply	other threads:[~2009-07-27  4:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 20:29 [PATCH] prom_init: evaluate mem kernel parameter for early allocation Benjamin Krill
2009-07-27  4:09 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248667777.5706.0.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=ben@codiert.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.