From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MVtuR-00016I-5v for mharc-grub-devel@gnu.org; Tue, 28 Jul 2009 17:08:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVtuP-00015X-8W for grub-devel@gnu.org; Tue, 28 Jul 2009 17:08:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVtuK-00013c-Tz for grub-devel@gnu.org; Tue, 28 Jul 2009 17:08:28 -0400 Received: from [199.232.76.173] (port=48785 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVtuK-00013W-Jq for grub-devel@gnu.org; Tue, 28 Jul 2009 17:08:24 -0400 Received: from mx20.gnu.org ([199.232.41.8]:3941) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MVtuK-0003xf-3p for grub-devel@gnu.org; Tue, 28 Jul 2009 17:08:24 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVtuJ-0001na-Aa for grub-devel@gnu.org; Tue, 28 Jul 2009 17:08:23 -0400 Received: from [85.180.13.133] (e180013133.adsl.alicedsl.de [85.180.13.133]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MKuxg-1MVtuG0gvq-0008UR; Tue, 28 Jul 2009 23:08:20 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090728181920.GM32726@thorin> References: <1244283931.3418.7.camel@fz.local> <1244339587.18630.8.camel@mj> <1244667896.8525.17.camel@fz.local> <20090728181920.GM32726@thorin> Content-Type: text/plain Date: Tue, 28 Jul 2009 23:09:11 +0200 Message-Id: <1248815351.3682.0.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.4 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/03pXGxm8yDxBkXOziBMvs418Xo0nkx1JPqnz xND02As4cQ3dcezY3J0Yw3LVwyDJxLo69LdtX4Bv6cMjmX8Tqa b/nwrKDCXPQMLV/64HHfg== X-Detected-Operating-System: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: 2273 lines in 170 files consists of only space and tabulators X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 21:08:29 -0000 Am Dienstag, den 28.07.2009, 20:19 +0200 schrieb Robert Millan: > On Wed, Jun 10, 2009 at 11:04:56PM +0200, Felix Zielcke wrote: > > Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin: > > > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote: > > > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l > > > > 2273 > > > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|sed -e 's/:.*//'|uniq|wc -l > > > > 170 > > > > > > > > Anyone wants me to do > > > > find . -type f -print0 | xargs -0 sed -i -r -e 's/^[[:blank:]]+$//' > > > > or does someone object? > > > > [:blank:] doestn't contain these ^L chars. > > > > > > > > By the way `git diff --color' shows if you introduce such a line with > > > > red, but strangely not when you remove one. > > > > > > Since we have linear development, it shouldn't be a problem for merging > > > patches. Besides, "patch" can be told to ignore whitespace differences. > > > > > > However, I would prefer that we remove all trailing whitespace, not just > > > that on empty lines. That is, remove "^" from the sed expression. > > > > Ok I just commited this. > > Do you mean removing all whitespace? I think you forgot to commit it. > > Though, I'd prefer if we don't do this in one megacommit. If we do it > gradually, we avoid breaking patches. This makes work easier for branches > and for distributors (which essentially operate as a branch). I did this in r2293 So you even didn't notice this. Good :) -- Felix Zielcke Proud Debian Maintainer