From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Bug fix for LVM
Date: Tue, 28 Jul 2009 23:37:13 +0200 [thread overview]
Message-ID: <1248817033.3682.3.camel@fz.local> (raw)
In-Reply-To: <20090728174223.GC32726@thorin>
Am Dienstag, den 28.07.2009, 19:42 +0200 schrieb Robert Millan:
> On Tue, Jul 28, 2009 at 11:15:09PM +0800, Bean wrote:
>
> > +static int
> > +probe_raid_level (grub_disk_t disk)
> > +{
> > + if (disk->dev->id != GRUB_DISK_DEVICE_RAID_ID)
> > + return -1;
> > +
> > + return ((struct grub_raid_array *) disk->data)->level;
> > +}
>
> Since this an ad-hoc function, could you put it in the same block that
> needs it? If 'static' qualifier is present, it won't result in nested
> function AFAICT.
>
GCC manual [0] says:
A nested function always has no linkage. Declaring one with extern or
static is erroneous.
[0]
http://gcc.gnu.org/onlinedocs/gcc-4.4.1/gcc/Nested-Functions.html#Nested-Functions
--
Felix Zielcke
Proud Debian Maintainer
next prev parent reply other threads:[~2009-07-28 21:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-18 14:11 [PATCH] Bug fix for LVM Bean
2009-07-18 19:11 ` Robert Millan
2009-07-18 19:43 ` Bean
2009-07-18 19:57 ` Robert Millan
2009-07-18 19:59 ` Vladimir 'phcoder' Serbinenko
2009-07-18 20:05 ` Robert Millan
2009-07-19 9:41 ` Bean
2009-07-22 17:29 ` Robert Millan
2009-07-22 17:33 ` Robert Millan
2009-07-22 18:58 ` Bean
2009-07-25 16:05 ` Robert Millan
2009-07-19 19:11 ` Patrik Horník
2009-07-19 19:34 ` Bean
2009-07-25 20:37 ` Felix Zielcke
2009-07-27 20:58 ` Patrik Horník
2009-07-28 3:27 ` Bean
2009-07-28 13:57 ` Bean
2009-07-28 15:15 ` Bean
2009-07-28 15:16 ` Bean
2009-07-28 17:42 ` Robert Millan
2009-07-28 21:37 ` Felix Zielcke [this message]
2009-07-29 3:22 ` Bean
2009-07-31 15:44 ` Robert Millan
2009-07-30 16:47 ` Patrik Horník
2009-07-31 4:41 ` Pavel Roskin
2009-07-31 14:28 ` Bean
2009-07-31 18:30 ` Felix Zielcke
2009-08-06 7:07 ` Felix Zielcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248817033.3682.3.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.