All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Erik Ziegenbalg <eziegenb@brocade.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] Mem: Fixes small memory leak due to missing free.
Date: Fri, 29 May 2015 19:42:35 +0200	[thread overview]
Message-ID: <12488353.7GeDSJAbkN@xps13> (raw)
In-Reply-To: <1432080295-8972-1-git-send-email-eziegenb@brocade.com>

2015-05-19 17:04, Erik Ziegenbalg:
> From: eziegenb <eziegenb@brocade.com>
> 
> A function in cmdline.c has a return that does not free buf properly.
> 
> Signed-off-by: Erik Ziegenbalg <eziegenb@brocade.com>

You forgot to add a changelog and the previous acked-by:
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: John McNamara <john.mcnamara@intel.com>

> -	if (ret < 0)
> +	if (ret < 0){

checkpatch complains about a missing space.

Applied with the above fix, thanks

      reply	other threads:[~2015-05-29 18:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  0:04 [PATCH v2] Mem: Fixes small memory leak due to missing free Erik Ziegenbalg
2015-05-29 17:42 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12488353.7GeDSJAbkN@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=eziegenb@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.