From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751580AbZG2IcY (ORCPT ); Wed, 29 Jul 2009 04:32:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751184AbZG2IcX (ORCPT ); Wed, 29 Jul 2009 04:32:23 -0400 Received: from viefep15-int.chello.at ([62.179.121.35]:53719 "EHLO viefep15-int.chello.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbZG2IcW (ORCPT ); Wed, 29 Jul 2009 04:32:22 -0400 X-SourceIP: 213.93.53.227 Subject: Re: perf_counter: hook up the tracepoint events From: Peter Zijlstra To: Jeff Garzik Cc: mingo@redhat.com, hpa@zytor.com, tglx@linutronix.de, mingo@elte.hu, paulus@samba.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, linux-tip-commits@vger.kernel.org In-Reply-To: <4A6F9F51.4010107@garzik.org> References: <20090319194233.744044174@chello.nl> <4A6F9F51.4010107@garzik.org> Content-Type: text/plain Date: Wed, 29 Jul 2009 10:35:08 +0200 Message-Id: <1248856508.6987.3041.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2009-07-28 at 21:01 -0400, Jeff Garzik wrote: > Peter Zijlstra wrote: > > diff --git a/init/Kconfig b/init/Kconfig > > index 8a38443..761129a 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -945,6 +945,11 @@ config PERF_COUNTERS > > > > Say Y if unsure. > > > > +config EVENT_PROFILE > > + bool "Tracepoint profile sources" > > + depends on PERF_COUNTERS && EVENT_TRACER > > + default y > > + > > endmenu > > Adding help text would be... helpful. :) > > The net result in this case was the addition of a completely-unexplained > Kconfig option late in 2.6.31-rc. > > Maybe the x86 maintainers could help see that they don't push > unexplained Kconfig options upstream -- particularly ones we are asked > to enable by default? You're right. Johannes Berg made the same complaint yesterday. Is the below any good? --- Subject: perf_counter: Add help text to CONFIG_EVENT_PROFILE Explain what tracepoint profile sources is about. Signed-off-by: Peter Zijlstra --- init/Kconfig | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index 13473ac..ffae67c 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -957,6 +957,12 @@ config EVENT_PROFILE bool "Tracepoint profile sources" depends on PERF_COUNTERS && EVENT_TRACING default y + help + Allow the use of tracepoints as software performance counters. + + When this is enabled, you can create perf counters based on + tracepoints using PERF_TYPE_TRACEPOINT and the tracepoint ID + found in debugfs://tracing/events/*/*/id. endmenu