From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1MWHRH-0005kh-S4
	for mharc-grub-devel@gnu.org; Wed, 29 Jul 2009 18:15:59 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWHRE-0005jE-GN
	for grub-devel@gnu.org; Wed, 29 Jul 2009 18:15:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWHR9-0005gq-0r
	for grub-devel@gnu.org; Wed, 29 Jul 2009 18:15:55 -0400
Received: from [199.232.76.173] (port=39395 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWHR8-0005gc-RL
	for grub-devel@gnu.org; Wed, 29 Jul 2009 18:15:50 -0400
Received: from c60.cesmail.net ([216.154.195.49]:36245)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16)
	(Exim 4.60) (envelope-from <proski@gnu.org>) id 1MWHR8-0005YU-An
	for grub-devel@gnu.org; Wed, 29 Jul 2009 18:15:50 -0400
Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112])
	by c60.cesmail.net with ESMTP; 29 Jul 2009 18:15:48 -0400
Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net
	[72.92.88.10])
	by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 118BE34C6D
	for <grub-devel@gnu.org>; Wed, 29 Jul 2009 18:27:24 -0400 (EDT)
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <DCE5739C-39C0-455F-8BEB-FC6A5FE4F42D@gmail.com>
References: <DCE5739C-39C0-455F-8BEB-FC6A5FE4F42D@gmail.com>
Content-Type: text/plain
Date: Wed, 29 Jul 2009 18:15:45 -0400
Message-Id: <1248905745.4253.14.camel@mj>
Mime-Version: 1.0
X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) 
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] gfxterm clear_char
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2009 22:15:56 -0000

On Tue, 2009-07-28 at 22:15 -0700, Joe Auricchio wrote:

> Eine kleine gfxterm.c cleanup

Applied with formatting changes.

>  static void
> +clear_char(struct grub_colored_char *c)

Space is needed before the parenthesis.

> +{
> +    c->code = ' ';

Indentation should be 2 spaces, not 4.

>    for(i = 0; i < virtual_screen.columns * virtual_screen.rows; i++)
>      {

This brace is no longer needed.

> Index: src/ChangeLog

It would be more convenient if the ChangeLog entry is posted inline
rather than inside the patch.

-- 
Regards,
Pavel Roskin