From: Pavel Roskin <proski@gnu.org>
To: Joerg Albert <jal2@gmx.de>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] compat-2.6: Makefile: fixed test expressions for target install
Date: Thu, 30 Jul 2009 17:42:16 -0400 [thread overview]
Message-ID: <1248990136.10154.10.camel@mj> (raw)
In-Reply-To: <4A720FE4.4020301@gmx.de>
On Thu, 2009-07-30 at 23:25 +0200, Joerg Albert wrote:
> This removes the two errors of [ with target "install"
>
> make[1]: Leaving directory `/home/joerg/src/linux-2.6.30'
> [: 9: missing ]
> [: 9: missing ]
> depmod will prefer updates/ over kernel/ -- OK!
I believe "-a" in test is not very portable. I remember getting
complaints about it. I believe the built-in test command in bash 1.x
doesn't have it. I'd rather stick with && and || written properly.
"-a" and -o" are currently only used in the clean target and in the
maintenance scripts, so they probably don't get enough testing on
systems with old bash.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-30 21:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 21:25 [PATCH] compat-2.6: Makefile: fixed test expressions for target install Joerg Albert
2009-07-30 21:42 ` Pavel Roskin [this message]
2009-07-31 18:50 ` Joerg Albert
2009-07-31 18:56 ` Pavel Roskin
2009-07-31 19:04 ` Luis R. Rodriguez
2009-07-31 23:15 ` Joerg Albert
2009-07-31 23:22 ` Luis R. Rodriguez
2009-08-01 10:39 ` Joerg Albert
2009-08-05 18:32 ` Luis R. Rodriguez
2009-07-31 23:21 ` [PATCH v2] " Joerg Albert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248990136.10154.10.camel@mj \
--to=proski@gnu.org \
--cc=jal2@gmx.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.