From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MWuHI-0006T5-66 for mharc-grub-devel@gnu.org; Fri, 31 Jul 2009 11:44:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWuHH-0006T0-0Z for grub-devel@gnu.org; Fri, 31 Jul 2009 11:44:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWuHC-0006SY-Mg for grub-devel@gnu.org; Fri, 31 Jul 2009 11:44:14 -0400 Received: from [199.232.76.173] (port=37754 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWuHC-0006SR-Es for grub-devel@gnu.org; Fri, 31 Jul 2009 11:44:10 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]:54973) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWuHB-0001vX-Ql for grub-devel@gnu.org; Fri, 31 Jul 2009 11:44:10 -0400 Received: from [85.180.60.62] (e180060062.adsl.alicedsl.de [85.180.60.62]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1MWuH82W42-000bQI; Fri, 31 Jul 2009 17:44:06 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090731153952.GA14675@thorin> References: <1244283931.3418.7.camel@fz.local> <1244339587.18630.8.camel@mj> <1244667896.8525.17.camel@fz.local> <20090728181920.GM32726@thorin> <1248815351.3682.0.camel@fz.local> <20090731153952.GA14675@thorin> Content-Type: text/plain Date: Fri, 31 Jul 2009 17:45:01 +0200 Message-Id: <1249055101.3635.4.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.4 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/5ntqSwWvugnzLTdOihk7atZZQQLB4MQbI348 oS8ap1QRH53YdTPHcaqRguLV6nWnWdXeBeRfPGj6EL+2oLMWuJ nwhxl1JKlkziw0rQ86Wvg== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: 2273 lines in 170 files consists of only space and tabulators X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 15:44:15 -0000 Am Freitag, den 31.07.2009, 17:39 +0200 schrieb Robert Millan: > On Tue, Jul 28, 2009 at 11:09:11PM +0200, Felix Zielcke wrote: > > Am Dienstag, den 28.07.2009, 20:19 +0200 schrieb Robert Millan: > > > On Wed, Jun 10, 2009 at 11:04:56PM +0200, Felix Zielcke wrote: > > > > Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin: > > > > > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote: > > > > > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l > > > > > > 2273 > > > > > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|sed -e 's/:.*//'|uniq|wc -l > > > > > > 170 > > > > > > > > > > > > Anyone wants me to do > > > > > > find . -type f -print0 | xargs -0 sed -i -r -e 's/^[[:blank:]]+$//' > > > > > > or does someone object? > > > > > > [:blank:] doestn't contain these ^L chars. > > > > > > > > > > > > By the way `git diff --color' shows if you introduce such a line with > > > > > > red, but strangely not when you remove one. > > > > > > > > > > Since we have linear development, it shouldn't be a problem for merging > > > > > patches. Besides, "patch" can be told to ignore whitespace differences. > > > > > > > > > > However, I would prefer that we remove all trailing whitespace, not just > > > > > that on empty lines. That is, remove "^" from the sed expression. > > > > > > > > Ok I just commited this. > > > > > > Do you mean removing all whitespace? I think you forgot to commit it. > > > > > > Though, I'd prefer if we don't do this in one megacommit. If we do it > > > gradually, we avoid breaking patches. This makes work easier for branches > > > and for distributors (which essentially operate as a branch). > > > > I did this in r2293 > > So you even didn't notice this. Good :) > > But there was no ChangeLog entry? > Uhm I thought this wasn't needed because the actual code didn't change. But okay GCS talks about all changes made to source files so you're probable right. -- Felix Zielcke Proud Debian Maintainer