From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MWuoL-0002hm-Sp for mharc-grub-devel@gnu.org; Fri, 31 Jul 2009 12:18:25 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWuoK-0002ha-5V for grub-devel@gnu.org; Fri, 31 Jul 2009 12:18:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWuoF-0002fb-GQ for grub-devel@gnu.org; Fri, 31 Jul 2009 12:18:23 -0400 Received: from [199.232.76.173] (port=48663 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWuoF-0002fU-Bk for grub-devel@gnu.org; Fri, 31 Jul 2009 12:18:19 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:57727) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWuoE-0001ae-K1 for grub-devel@gnu.org; Fri, 31 Jul 2009 12:18:19 -0400 Received: from [85.180.60.62] (e180060062.adsl.alicedsl.de [85.180.60.62]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MKt2u-1MWuoD1n8w-000dFT; Fri, 31 Jul 2009 18:18:17 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090731160748.GG14675@thorin> References: <20090728181513.GK32726@thorin> <20090731160748.GG14675@thorin> Content-Type: text/plain Date: Fri, 31 Jul 2009 18:19:11 +0200 Message-Id: <1249057151.3635.6.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.4 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX18QERUKG/1Ms+bgzztzvjESrYqsmiTv3ebAO3t n9dEKGKM8ZJ9uv9zidiwi6VExJ/CTIu4XZyClllt3PAIPX50kX jAfLAvpqYR2hrQl6QljJE2MjZd9n1Lz X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix CPUID documentation and return values X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 16:18:24 -0000 Am Freitag, den 31.07.2009, 18:07 +0200 schrieb Robert Millan: > On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan wrote: > > > On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > >> Hello. CPUID command currently doesn't return a real grub_err_t and > > >> errors aren't set which doesn't fit in grub2's design. > > >> Addirionally "help cpuid" doesn't give really useful info. So for > > >> future expandability and less confusion I propose the attached patch > > >> partially based on original patch by Robert Millan > > > > > > Hi, > > > > > > I don't remember about this patch. I assume I wrote it in 2007 when > > > merging cpuid support for first time. > > Yes, it is. > > > Any idea why it wasn't it committed > > > back then? > > > > > None. Yoshinori K Okuji approved it here: > > http://lists.gnu.org/archive/html/grub-devel/2007-05/msg00148.html > > I vaguely recall having disabled it because there was some issue with > scripting. Assuming it's working properly now, I have no objection with > it. > There was one. if [ 0=1 ] ; then echo t ; else echo f ; fi did print t but then also `error: false' This is now fixed. -- Felix Zielcke Proud Debian Maintainer