From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MWuvk-000090-PP for mharc-grub-devel@gnu.org; Fri, 31 Jul 2009 12:26:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWuvj-00007T-7m for grub-devel@gnu.org; Fri, 31 Jul 2009 12:26:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWuve-0008SY-EH for grub-devel@gnu.org; Fri, 31 Jul 2009 12:26:02 -0400 Received: from [199.232.76.173] (port=40439 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWuve-0008S9-A5 for grub-devel@gnu.org; Fri, 31 Jul 2009 12:25:58 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:54208) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWuvd-0003Ay-GB for grub-devel@gnu.org; Fri, 31 Jul 2009 12:25:57 -0400 Received: from [85.180.60.62] (e180060062.adsl.alicedsl.de [85.180.60.62]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MKsym-1MWuvc2kdc-000XEj; Fri, 31 Jul 2009 18:25:56 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090731160546.GF14675@thorin> References: <1248617131.25072.13.camel@fz.local> <20090728181234.GI32726@thorin> <1248857003.3729.0.camel@fz.local> <20090731160546.GF14675@thorin> Content-Type: text/plain Date: Fri, 31 Jul 2009 18:26:51 +0200 Message-Id: <1249057611.3635.11.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.4 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX188/ZoUBOTRWtsY0N3lXXwmQiocvTY8sf/B1ND dopfG+H61NbqQrT6MMTWVaTOj87tgQm9gKOQgUWavZ577V+MCC OKi4EqKmJEuXqBj8qWIVM1lbovcSgpT X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] use UUID to map system devices to grub devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 16:26:03 -0000 Am Freitag, den 31.07.2009, 18:05 +0200 schrieb Robert Millan: > On Wed, Jul 29, 2009 at 10:43:23AM +0200, Felix Zielcke wrote: > > Am Dienstag, den 28.07.2009, 20:12 +0200 schrieb Robert Millan: > > > On Sun, Jul 26, 2009 at 04:05:31PM +0200, Felix Zielcke wrote: > > > > As requested by Robert on IRC, this is a split from my dmraid patch. > > > > On dmraid devices HDIO_GETGEO returns 0 for all fields, so the current > > > > way of grub_util_biosdisk_get_grub_dev just can't work. > > > > So I use blkid to get the UUID of the device and then a new nested > > > > function to find out the grub device like search does. > > > > > > > > I think this is with intent from the kernel that it just returns 0's. > > > > Maybe it just can't distinguish between a device mapper setup which goes > > > > over multiple partitions or harddisks of different size not from one > > > > which goes only over complete harddisks with same size like in dmraid > > > > Hm but even if, I think it wouldn't help in case of RAID != 1. Sector > > > > count could be > then last sector of one disk or not? > > > > > > I keep thinking this is an overkill solution. We should to discuss more about > > > what's the problem we need to fix, and only ressort to this if we have no > > > other choice. > > > > > > > The problem is how do we map a device file to a grub device. > > Especially BSD partitions which only have numbers under Linux? > > I don't know how the devices are called under BSD. > > What does grub device mean in this context? If we're strictly in util/ land, > any arbitrary map will do as long as it's consistent. > If we're in both places, we already avoid making assumptions that there will > be consistency between them, so we don't need to make them now. If we'd do an arbitrary mapping then `grub-probe -t drive' would show the wrong grub device. But except from this I think that would be okay. -- Felix Zielcke Proud Debian Maintainer