From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MWvAA-0002MM-S5 for mharc-grub-devel@gnu.org; Fri, 31 Jul 2009 12:40:58 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWvA8-0002Lg-NI for grub-devel@gnu.org; Fri, 31 Jul 2009 12:40:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWvA3-0002Jq-KY for grub-devel@gnu.org; Fri, 31 Jul 2009 12:40:56 -0400 Received: from [199.232.76.173] (port=54934 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWvA3-0002Jj-C5 for grub-devel@gnu.org; Fri, 31 Jul 2009 12:40:51 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:50154) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWvA2-0005vQ-OR for grub-devel@gnu.org; Fri, 31 Jul 2009 12:40:51 -0400 Received: from [85.180.60.62] (e180060062.adsl.alicedsl.de [85.180.60.62]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0MKv1o-1MWvA13flT-000oyM; Fri, 31 Jul 2009 18:40:50 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090731162632.GL14675@thorin> References: <20090728181513.GK32726@thorin> <20090731160748.GG14675@thorin> <1249057151.3635.6.camel@fz.local> <20090731162632.GL14675@thorin> Content-Type: text/plain Date: Fri, 31 Jul 2009 18:41:44 +0200 Message-Id: <1249058504.3635.14.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.4 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+VK3UI5/l/LR7Y8AhIGZldBpa6DuuyoUSXC/D ArTh14I9n4i9btEl0YUDJ1zKoZ19YLVuD38skdQAwC421PDDeP 5gLWoW3HRr5dS7XPcjxJA== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix CPUID documentation and return values X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 16:40:57 -0000 Am Freitag, den 31.07.2009, 18:26 +0200 schrieb Robert Millan: > On Fri, Jul 31, 2009 at 06:19:11PM +0200, Felix Zielcke wrote: > > Am Freitag, den 31.07.2009, 18:07 +0200 schrieb Robert Millan: > > > On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > > On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan wrote: > > > > > On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > > >> Hello. CPUID command currently doesn't return a real grub_err_t and > > > > >> errors aren't set which doesn't fit in grub2's design. > > > > >> Addirionally "help cpuid" doesn't give really useful info. So for > > > > >> future expandability and less confusion I propose the attached patch > > > > >> partially based on original patch by Robert Millan > > > > > > > > > > Hi, > > > > > > > > > > I don't remember about this patch. I assume I wrote it in 2007 when > > > > > merging cpuid support for first time. > > > > Yes, it is. > > > > > Any idea why it wasn't it committed > > > > > back then? > > > > > > > > > None. Yoshinori K Okuji approved it here: > > > > http://lists.gnu.org/archive/html/grub-devel/2007-05/msg00148.html > > > > > > I vaguely recall having disabled it because there was some issue with > > > scripting. Assuming it's working properly now, I have no objection with > > > it. > > > > > > > There was one. > > if [ 0=1 ] ; then echo t ; else echo f ; fi > > did print t but then also `error: false' > > This is now fixed. > > But the cpuid CLI worked differently, IIRC > Ah in the thread you said that `if cpuid --long-mode; then ...; else ...; fi' doestn't work. But I just tested this with `if cpuid --long-mode; then echo true; else echo false; fi' in qemu and in 32bit I get false and in 64bit I get true. -- Felix Zielcke Proud Debian Maintainer