All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Schummer" <ext-jorg.2.schummer@nokia.com>
To: ext OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label
Date: Tue, 04 Aug 2009 11:42:37 +0300	[thread overview]
Message-ID: <1249375357.5736.53.camel@jorg-desktop> (raw)
In-Reply-To: <87ljmas5ym.fsf@devron.myhome.or.jp>

On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote:
> Jörg Schummer <ext-jorg.2.schummer@nokia.com> writes:

> BTW, the patch has several bugs. fat_get_label_entry() doesn't check
> IS_FREE(), is it right? fat_create_label_entry() doesn't initialize all
> timestamp in the case of msdos. spin_lock() usage is wrong. and more...

After reviewing the patch again, I did notice some additional problems
(I suppose that was the "and more..."). If and when I have time again, I
might take a closer look at it again.

Thanks for your help until now!

Jörg



  parent reply	other threads:[~2009-08-04  8:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22 15:00 [PATCH][RFC] fat: Save FAT root directory timestamps to volume label Jorg Schummer
2009-07-24  9:43 ` [PATCH take 2][RFC] " Jorg Schummer
2009-07-25  5:48   ` OGAWA Hirofumi
2009-07-27 10:47     ` Jörg Schummer
2009-07-27 10:47       ` Jörg Schummer
2009-07-27 11:47       ` OGAWA Hirofumi
2009-07-27 11:47         ` OGAWA Hirofumi
2009-07-27 13:03         ` Jörg Schummer
2009-07-27 13:03           ` Jörg Schummer
2009-07-27 14:56         ` Jörg Schummer
2009-07-27 14:56           ` Jörg Schummer
2009-07-27 15:10           ` OGAWA Hirofumi
2009-07-27 15:10             ` OGAWA Hirofumi
2009-08-04  8:42         ` Jörg Schummer [this message]
2009-08-04 10:32           ` OGAWA Hirofumi
2009-08-04 10:32             ` OGAWA Hirofumi
2009-09-08 14:28             ` [PATCH take 3][RFC] " Jörg Schummer
2009-09-08 14:28               ` Jörg Schummer
2009-09-08 14:34               ` Jorg Schummer
2009-09-08 15:39                 ` Jamie Lokier
2009-09-09  7:47                   ` Jörg Schummer
2009-09-09  7:47                     ` Jörg Schummer
2009-09-15 11:03                 ` Jörg Schummer
2009-09-15 11:03                   ` Jörg Schummer
2009-09-18 11:33                 ` OGAWA Hirofumi
2009-09-18 12:14                   ` jorg
2009-09-19 14:46                     ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249375357.5736.53.camel@jorg-desktop \
    --to=ext-jorg.2.schummer@nokia.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.