Re: [PATCH] ethtool: Add "-f" option to flash firmware image to a network device.

[Ben Hutchings <bhutchings@solarflare.com>]

On Wed, 2009-08-05 at 18:01 +0530, Ajit Khaparde wrote:
> Attached  is a patch for ethtool utility to add a new "-f" option.
> This will enable flashing a firmware image to a network interface.

Which firmware?  There can be several firmware images for controller,
PHY, host boot "ROM" and others.

[...]
> @@ -2398,6 +2404,20 @@ static int do_grxclass(int fd, struct ifreq
> *ifr)
>  	return 0;
>  }
>  
> +static int do_flash(int fd, struct ifreq *ifr)
> +{
> +	int err;
> +	struct ethtool_value ecmd;
> +
> +	ecmd.cmd = ETHTOOL_FLASHDEV;
> +	ifr->ifr_data = (caddr_t)&ecmd;
> +	err = send_ioctl(fd, ifr);
> +	if (err < 0)
> +		perror("Flashing failed");
[..]

Where does the image come from?  The running code?  What about static
variables that have changed since startup?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.