All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinz Mauelshagen <heinzm@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 2/2] Disable partition scan
Date: Wed, 05 Aug 2009 15:17:05 +0200	[thread overview]
Message-ID: <1249478225.17021.48.camel@o> (raw)
In-Reply-To: <1248281597.14407.171.camel@breeves.fab.redhat.com>

On Wed, 2009-07-22 at 17:53 +0100, Bryn M. Reeves wrote:
> On Wed, 2009-07-22 at 10:01 +0200, Hannes Reinecke wrote:
> > Worse, it might trigger I/O errors as the partition table might not
> > be accessible (eg for the passive path of a multipath device) or
> > even invalid (eg for RAID0 dmraid).
> 
> Not that it removes the need or motivation for this patch but the case
> of an array partition table being mis-interpreted by the kernel for a
> RAID member device should no longer trigger I/O errors. Kernels since
> 2.6.27 should truncate any over-size partitions to the size of the
> device:
> 
> commit ac0d86f5809598ddcd6bfa0ea8245ccc910e9eac
> Author: Kay Sievers <kay.sievers@vrfy.org>
> Date:   Wed Oct 15 22:04:21 2008 -0700
> 
>     block: sanitize invalid partition table entries
>     
>     We currently follow blindly what the partition table lies about the
>     disk, and let the kernel create block devices which can not be
>     accessed.
>     Trying to identify the device leads to kernel logs full of:
>       sdb: rw=0, want=73392, limit=28800
>       attempt to access beyond end of device
> [snip]
> 
> I've tested this patch with a few dmraid setups that previously spat I/O
> errors whenever something probed a member device. Although this isn't
> exactly a solution it does quiet down the log noise (I'd thought about
> submitting a patch to dmraid to issue a BLKPG_DEL_PARTITION for each
> partition on each member device that it discovers but didn't get around
> to doing anything about it yet).

We've got that in RHEL/Fedora dmraid already with option
"--rm_partitions".

Regards,
Heinz

> 
> Regards,
> Bryn.
> 
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

      reply	other threads:[~2009-08-05 13:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22  8:01 [PATCH 2/2] Disable partition scan Hannes Reinecke
2009-07-22 16:53 ` Bryn M. Reeves
2009-08-05 13:17   ` Heinz Mauelshagen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249478225.17021.48.camel@o \
    --to=heinzm@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.