From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MZcyu-00081r-TT for mharc-grub-devel@gnu.org; Fri, 07 Aug 2009 23:52:32 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MZcyt-00081k-0Y for grub-devel@gnu.org; Fri, 07 Aug 2009 23:52:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MZcyo-0007zu-Ih for grub-devel@gnu.org; Fri, 07 Aug 2009 23:52:30 -0400 Received: from [199.232.76.173] (port=39075 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MZcyo-0007zr-FG for grub-devel@gnu.org; Fri, 07 Aug 2009 23:52:26 -0400 Received: from c60.cesmail.net ([216.154.195.49]:50010) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MZcyn-0001rp-Uh for grub-devel@gnu.org; Fri, 07 Aug 2009 23:52:26 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 07 Aug 2009 23:52:24 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 800C634C6D for ; Sat, 8 Aug 2009 00:05:22 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20090804205256.GE15811@thorin> <20090807110654.GC6695@thorin> <87bpmrj2l1.fsf@xs4all.nl> Content-Type: text/plain Date: Fri, 07 Aug 2009 23:52:22 -0400 Message-Id: <1249703542.25983.42.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH 1/2] Relocator framework X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2009 03:52:31 -0000 On Fri, 2009-08-07 at 14:01 +0200, Vladimir 'phcoder' Serbinenko wrote: > Apple's compiler is based GCC but binutils aren't and they pose the > most of problems. Actualy the most problematic bit was that I didn't > know that unless you prefix variable with L_ apple's assembler treats > it as global. Adding L_ in this code solves problem. Yves proposed to > add a LOCAL(x) macro to symbol.h this way the assembler code is also > more readable. I also did further adjustments in this patch to > decrease the number of ifdefs but had no time to test it and so > couldn't submit it I would prefer if you don't commit any patches that introduce any more preprocessor conditionals for the Apple compiler or assembler. It would make it hard to debug problems reported by others, as different compilers would produce different binaries. If we are using some feature that is just nice but not needed (such as binary & in lnxboot.S to set the image size to 1024), it would be better to avoid using that feature for all compilers rather than for the compilers that don't support it. -- Regards, Pavel Roskin