From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MZeEE-0005OS-UN for mharc-grub-devel@gnu.org; Sat, 08 Aug 2009 01:12:27 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MZeEB-0005Ny-Ae for grub-devel@gnu.org; Sat, 08 Aug 2009 01:12:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MZeE6-0005N5-R2 for grub-devel@gnu.org; Sat, 08 Aug 2009 01:12:22 -0400 Received: from [199.232.76.173] (port=35323 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MZeE6-0005Mm-JP for grub-devel@gnu.org; Sat, 08 Aug 2009 01:12:18 -0400 Received: from c60.cesmail.net ([216.154.195.49]:10784) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MZeE6-0004nz-7B for grub-devel@gnu.org; Sat, 08 Aug 2009 01:12:18 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 08 Aug 2009 01:12:17 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id A0C0A34C6D for ; Sat, 8 Aug 2009 01:25:15 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1249649867.3592.11.camel@fz.local> References: <1249551551.3663.7.camel@fz.local> <20090807113928.GM6695@thorin> <1249646572.3592.10.camel@fz.local> <1249649867.3592.11.camel@fz.local> Content-Type: text/plain Date: Sat, 08 Aug 2009 01:12:15 -0400 Message-Id: <1249708335.28996.21.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] move functionality of font_path() directly to util/grub-mkconfig.in and prefer unicode.pf2 over ascii.pf2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2009 05:12:23 -0000 On Fri, 2009-08-07 at 14:57 +0200, Felix Zielcke wrote: > I commited it now with an ack from Robert on IRC. Sorry, I'm commenting after it has been committed. Anyway, please note that having an approval doesn't absolve you from testing the code on your own. Reviews are not testing. There was a warning introduced by your change, and there was a syntax error after "ascii". Also, the formatting of the moved code should have been changed to use the same indentation as the target file. I have fixed all that. Could you please explain what I should do to keep using ascii.pf2? I checked the script, but don't see any variable controlling that. "make install" would install both unicode.pf2 and ascii.pf2, so unicode.pf2 would always be preferred. If changing the default, it's a good style to provide an easy way for users to keep the old setting, and I just don't see it, short or removing /usr/src/unifont.bdf and /usr/local/share/grub/unicode.pf2 so that they are never reinstalled or detected by GRUB. -- Regards, Pavel Roskin