From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MZefC-0005sf-3p for mharc-grub-devel@gnu.org; Sat, 08 Aug 2009 01:40:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MZef9-0005sP-KJ for grub-devel@gnu.org; Sat, 08 Aug 2009 01:40:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MZef4-0005r6-VY for grub-devel@gnu.org; Sat, 08 Aug 2009 01:40:15 -0400 Received: from [199.232.76.173] (port=56485 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MZef4-0005r3-C0 for grub-devel@gnu.org; Sat, 08 Aug 2009 01:40:10 -0400 Received: from mx20.gnu.org ([199.232.41.8]:55812) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MZef3-0004JW-V8 for grub-devel@gnu.org; Sat, 08 Aug 2009 01:40:10 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MZef3-0007Sv-1Y for grub-devel@gnu.org; Sat, 08 Aug 2009 01:40:09 -0400 Received: from [85.180.53.154] (e180053154.adsl.alicedsl.de [85.180.53.154]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1MZef12eZo-000cPq; Sat, 08 Aug 2009 07:40:07 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <1249709780.3537.14.camel@fz.local> References: <1249551551.3663.7.camel@fz.local> <20090807113928.GM6695@thorin> <1249646572.3592.10.camel@fz.local> <1249649867.3592.11.camel@fz.local> <1249708335.28996.21.camel@mj> <1249709780.3537.14.camel@fz.local> Content-Type: text/plain Date: Sat, 08 Aug 2009 07:41:07 +0200 Message-Id: <1249710067.3537.15.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.5 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX19T0ri4KjuVrq8ErBkG7yarU6iG/G3L3+KdvEL iqenGt8KsYJ/4fiIAIBImHFZ79Z1YxkvtGi5HvbsfS1Acj7M/m tDjeBtNY5f6k/YUHR879Q== X-Detected-Operating-System: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] move functionality of font_path() directly to util/grub-mkconfig.in and prefer unicode.pf2 over ascii.pf2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2009 05:40:16 -0000 Am Samstag, den 08.08.2009, 07:36 +0200 schrieb Felix Zielcke: > Am Samstag, den 08.08.2009, 01:12 -0400 schrieb Pavel Roskin: > > On Fri, 2009-08-07 at 14:57 +0200, Felix Zielcke wrote: > > > > > I commited it now with an ack from Robert on IRC. > > > > Sorry, I'm commenting after it has been committed. Anyway, please note > > that having an approval doesn't absolve you from testing the code on > > your own. Reviews are not testing. There was a warning introduced by > > your change, and there was a syntax error after "ascii". Also, the > > formatting of the moved code should have been changed to use the same > > indentation as the target file. I have fixed all that. > > Sorry. > > > Could you please explain what I should do to keep using ascii.pf2? I > > checked the script, but don't see any variable controlling that. "make > > install" would install both unicode.pf2 and ascii.pf2, so unicode.pf2 > > would always be preferred. > > With the old code ascii.pf2 would be always preferred. > There wasn't either a way to specify it. > > > If changing the default, it's a good style to provide an easy way for > > users to keep the old setting, and I just don't see it, short or > > removing /usr/src/unifont.bdf and /usr/local/share/grub/unicode.pf2 so > > that they are never reinstalled or detected by GRUB. > > Here's now a patch which allows users to specifiy the used font with > GRUB_FONT=ascii > Oh I forgot to mention that I left the indent changes with intent out, so it's more readable. -- Felix Zielcke Proud Debian Maintainer