From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MZeoC-0008Dl-GA for mharc-grub-devel@gnu.org; Sat, 08 Aug 2009 01:49:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MZeoA-0008DN-EF for grub-devel@gnu.org; Sat, 08 Aug 2009 01:49:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MZeo5-0008CQ-Ip for grub-devel@gnu.org; Sat, 08 Aug 2009 01:49:33 -0400 Received: from [199.232.76.173] (port=39534 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MZeo5-0008CL-FQ for grub-devel@gnu.org; Sat, 08 Aug 2009 01:49:29 -0400 Received: from c60.cesmail.net ([216.154.195.49]:25355) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MZeo4-00077v-Ir for grub-devel@gnu.org; Sat, 08 Aug 2009 01:49:28 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 08 Aug 2009 01:49:27 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 3333534C6D for ; Sat, 8 Aug 2009 02:02:26 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1249709780.3537.14.camel@fz.local> References: <1249551551.3663.7.camel@fz.local> <20090807113928.GM6695@thorin> <1249646572.3592.10.camel@fz.local> <1249649867.3592.11.camel@fz.local> <1249708335.28996.21.camel@mj> <1249709780.3537.14.camel@fz.local> Content-Type: text/plain Date: Sat, 08 Aug 2009 01:49:25 -0400 Message-Id: <1249710565.28996.43.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] move functionality of font_path() directly to util/grub-mkconfig.in and prefer unicode.pf2 over ascii.pf2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2009 05:49:35 -0000 On Sat, 2009-08-08 at 07:36 +0200, Felix Zielcke wrote: > > Could you please explain what I should do to keep using ascii.pf2? I > > checked the script, but don't see any variable controlling that. "make > > install" would install both unicode.pf2 and ascii.pf2, so unicode.pf2 > > would always be preferred. > > With the old code ascii.pf2 would be always preferred. > There wasn't either a way to specify it. I see. Maybe that's what we should have fixed first. > > If changing the default, it's a good style to provide an easy way for > > users to keep the old setting, and I just don't see it, short or > > removing /usr/src/unifont.bdf and /usr/local/share/grub/unicode.pf2 so > > that they are never reinstalled or detected by GRUB. > > Here's now a patch which allows users to specifiy the used font with > GRUB_FONT=ascii First of all, I hope that the patch you will actually commit will use sane formatting. Diffs that ignore spacing changes are OK for review, but not for applying as is. I think it would be more natural to let the user specify the full path to the file. Setting LANG=C seems unneeded in this case. After all, it's the user's choice, and we cannot examine the font file to check which characters it has. -- Regards, Pavel Roskin