From: Artem Bityutskiy <dedekind@infradead.org>
To: "Leo (Hao) Chen" <leochen@broadcom.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-arm-kernel@lists.arm.linux.org.uk"
<linux-arm-kernel@lists.arm.linux.org.uk>
Subject: RE: [PATCH v3 26/27] [ARM] [NAND] [bcmring] add bcmring umi nand driver support
Date: Sun, 09 Aug 2009 08:16:25 +0300 [thread overview]
Message-ID: <1249794985.9157.36.camel@localhost> (raw)
In-Reply-To: <8628FE4E7912BF47A96AE7DD7BAC0AADCB25D06CDD@SJEXCHCCR02.corp.ad.broadcom.com>
Hi,
On Tue, 2009-07-28 at 15:38 -0700, Leo (Hao) Chen wrote:
> include/linux/mtd/nand_bcm_umi.h | 241 ++++++++
It does not look like you need to have this header file in
include/linux/mtd/. Also, this file contains huge inline functions,
which is not nice. We are trying not to make functions longer than
1-2 lines inline and let the compiler do the decisions. Of course,
there are exceptions, but your 'nand_bcm_umi_bch_correct_page' does
not look like this. Could you please go through all your inlines and
un-inline non-few-liners?
Sorry, I do not have time to do any real review, but from the stylistic
POW you have too many
/*********************************************************************/
things, as well as ThisLovelyWindowsStyle naming, which we do not
appreciate very much in the Linux Kernel.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-08-09 5:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 19:13 [PATCH v3 26/27] [ARM] [NAND] [bcmring] add bcmring umi nand driver support Leo (Hao) Chen
2009-07-19 5:08 ` Artem Bityutskiy
2009-07-19 10:56 ` Steve Chen
2009-07-21 22:46 ` Leo (Hao) Chen
2009-07-22 6:12 ` Artem Bityutskiy
2009-07-28 22:08 ` Leo (Hao) Chen
2009-07-28 22:38 ` Leo (Hao) Chen
2009-08-09 5:16 ` Artem Bityutskiy [this message]
2009-08-09 7:12 ` Scott Branden
2009-08-09 7:27 ` Artem Bityutskiy
2009-08-10 17:33 ` Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249794985.9157.36.camel@localhost \
--to=dedekind@infradead.org \
--cc=leochen@broadcom.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.