From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Brabec Subject: Re: ads7846: clean up, fix pressure reporting Date: Sun, 09 Aug 2009 12:21:33 +0200 Message-ID: <1249813293.4334.24.camel@utx.utx.cz> References: <20090807180941.GF1728@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20090807180941.GF1728@ucw.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.arm.linux.org.uk To: Pavel Machek Cc: dtor@mail.ru, linux-input@vger.kernel.org, rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@Opfer-Online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, linux-arm-kernel , dbaryshkov@gmail.com, omegamoon@gmail.com, eric.miao@marvell.comCyril Hrubis List-Id: linux-input@vger.kernel.org UGF2ZWwgTWFjaGVrIHdyb3RlOgo+IEZpeCBwcmVzc3VyZSByZXBvcnRpbmcsIGFuZCBjbGVhbiB1 cCBkZWJ1ZyBwcmludHMuCgpUaGFua3MuCgpJIHNlZSBtdWNoIGJpZ2dlciBwcm9ibGVtIHdpdGgg Ym90aCB0aGUgb2xkIGRyaXZlciBhbmQgdGhlIG5ldyBhZHM3ODQ2CmRyaXZlciAoMi42LjMwKTog VGhleSBhcmUgdmVyeSBub2lzeSBvbiBteSBzcGl0ei4gV2hlbiB5b3UgdGFwIHRvIG9uZQpwbGFj ZSwga2VlcCBzdHlsdXMgcHJlc3NlZCBhbmQganVzdCByZWFkIHZhbHVlcywgeW91IGdldCAyMC0y MDAgcGl4ZWxzCmxvbmcgcG9pbnRlciBtb3Rpb24gdHJpcCBlYWNoIHNlY29uZC4KCkFjY29yZGlu ZyB0byBDeXJpbCBIcnViacWhLCBpdCBpcyBjYXVzZWQgYnkgdGhlIGVsZWN0cmljYWwgbm9pc2Ug dGhhdApvcmlnaW5hdGVzIGluIHRoZSBMQ0QgZGlzcGxheS4gVGhlIGRyaXZlciBuZWVkcyB0byBy ZWFkIGRhdGEKc3luY2hyb25vdXNseSB3aXRoIHRoZSBMQ0QgcmVmcmVzaC4gSGUgYWxyZWFkeSBt YWRlIHRoZSBmaXggZm9yIGNvbGxpZQpzZXZlcmFsIHllYXJzIGFnby4K77u/ClRoZSBwb2ludGVy IHRlc3QgYXBwbGljYXRpb24gaW4gdGhlIFBST00gZGlhZ25vc3RpYyB1dGlsaXR5IGRvZXMgbm90 CnNlZW0gdG8gZXhoaWJpdCBhbnkgbm9pc2UuCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClN0YW5pc2xhdiBC cmFiZWMKaHR0cDovL3d3dy5wZW5ndWluLmN6L351dHgvemF1cnVzCgoKLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpMaXN0 IGFkbWluOiBodHRwOi8vbGlzdHMuYXJtLmxpbnV4Lm9yZy51ay9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwKRkFROiAgICAgICAgaHR0cDovL3d3dy5hcm0ubGludXgub3JnLnVrL21h aWxpbmdsaXN0cy9mYXEucGhwCkV0aXF1ZXR0ZTogIGh0dHA6Ly93d3cuYXJtLmxpbnV4Lm9yZy51 ay9tYWlsaW5nbGlzdHMvZXRpcXVldHRlLnBocA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751937AbZHIKk0 (ORCPT ); Sun, 9 Aug 2009 06:40:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751438AbZHIKkZ (ORCPT ); Sun, 9 Aug 2009 06:40:25 -0400 Received: from ns.penguin.cz ([84.21.108.25]:49326 "EHLO ns.penguin.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbZHIKkY (ORCPT ); Sun, 9 Aug 2009 06:40:24 -0400 X-Greylist: delayed 1114 seconds by postgrey-1.27 at vger.kernel.org; Sun, 09 Aug 2009 06:40:24 EDT Subject: Re: ads7846: clean up, fix pressure reporting From: Stanislav Brabec To: Pavel Machek Cc: dtor@mail.ru, linux-input@vger.kernel.org, rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@Opfer-Online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, linux-arm-kernel , dbaryshkov@gmail.com, omegamoon@gmail.com, eric.miao@marvell.com, Cyril Hrubis In-Reply-To: <20090807180941.GF1728@ucw.cz> References: <20090807180941.GF1728@ucw.cz> Content-Type: text/plain; charset=UTF-8 Date: Sun, 09 Aug 2009 12:21:33 +0200 Message-Id: <1249813293.4334.24.camel@utx.utx.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Machek wrote: > Fix pressure reporting, and clean up debug prints. Thanks. I see much bigger problem with both the old driver and the new ads7846 driver (2.6.30): They are very noisy on my spitz. When you tap to one place, keep stylus pressed and just read values, you get 20-200 pixels long pointer motion trip each second. According to Cyril Hrubiš, it is caused by the electrical noise that originates in the LCD display. The driver needs to read data synchronously with the LCD refresh. He already made the fix for collie several years ago.  The pointer test application in the PROM diagnostic utility does not seem to exhibit any noise. ________________________________________________________________________ Stanislav Brabec http://www.penguin.cz/~utx/zaurus