From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mercury.realtime.net ([205.238.132.86]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MaPbl-0003px-U5 for kexec@lists.infradead.org; Mon, 10 Aug 2009 07:47:58 +0000 From: Milton Miller Subject: Re: [PATCH] Do not inline putprops function In-Reply-To: <20090805164938.GA2970@in.ibm.com> Date: Mon, 10 Aug 2009 02:37:49 -0500 Message-ID: <1249889869_10618@mercury.realtime.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "M. Mohan Kumar" Cc: Michael Ellerman , kexec@lists.infradead.org, Simon Horman , linuxppc-dev@lists.ozlabs.org On Thu Aug 6 at about 02:49:38 EST in 2009, M. Mohan Kumar wrote: > > When I align the dtstruct variable to 8 bytes, I am able to invoke kdump. > > When the line > static unsigned dtstruct[TREEWORDS], *dt; > changed to > static unsigned dtstruct[TREEWORDS] __attribute__ ((aligned (8))), *dt; > > kexec-tool works. Doh. that is the correct fix. kexec is creating a version 3 device tree, to be backwards compatible as far as possible. (Well, that and it was written before version 3 existed). This version of the struct has 8-byte alignment for properties whose value is 8 or more bytes. As the code directly checks the pointer when deciding to add the alignment word, the struct memory must start on an 8 byte boundary. Mohan, please prepare a patch with the above text in the changelog and send it to Simon. thanks. milton _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 9B47DB70B0 for ; Mon, 10 Aug 2009 18:04:17 +1000 (EST) Received: from mercury.realtime.net (mercury.realtime.net [205.238.132.86]) by ozlabs.org (Postfix) with ESMTP id 98C96DDD04 for ; Mon, 10 Aug 2009 18:04:16 +1000 (EST) From: Milton Miller To: M. Mohan Kumar Subject: Re: [PATCH] Do not inline putprops function In-Reply-To: <20090805164938.GA2970@in.ibm.com> Date: Mon, 10 Aug 2009 02:37:49 -0500 Message-ID: <1249889869_10618@mercury.realtime.net> Cc: kexec@lists.infradead.org, Simon Horman , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu Aug 6 at about 02:49:38 EST in 2009, M. Mohan Kumar wrote: > > When I align the dtstruct variable to 8 bytes, I am able to invoke kdump. > > When the line > static unsigned dtstruct[TREEWORDS], *dt; > changed to > static unsigned dtstruct[TREEWORDS] __attribute__ ((aligned (8))), *dt; > > kexec-tool works. Doh. that is the correct fix. kexec is creating a version 3 device tree, to be backwards compatible as far as possible. (Well, that and it was written before version 3 existed). This version of the struct has 8-byte alignment for properties whose value is 8 or more bytes. As the code directly checks the pointer when deciding to add the alignment word, the struct memory must start on an 8 byte boundary. Mohan, please prepare a patch with the above text in the changelog and send it to Simon. thanks. milton