From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] mtd/maps: add mtd-ram support to physmap_of From: Artem Bityutskiy To: Wolfram Sang In-Reply-To: <20090810161942.GA27833@pengutronix.de> References: <1247834363-28198-1-git-send-email-w.sang@pengutronix.de> <1249795043.9157.37.camel@localhost> <20090810161942.GA27833@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Date: Mon, 10 Aug 2009 19:25:56 +0300 Message-Id: <1249921556.19638.16.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: devicetree-discuss@ozlabs.org, Vitaly Wool , Albrecht =?ISO-8859-1?Q?Dre=DF?= , Grant Likely , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, Ken MacLeod , David Woodhouse Reply-To: dedekind@infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2009-08-10 at 18:19 +0200, Wolfram Sang wrote: > On Sun, Aug 09, 2009 at 08:17:23AM +0300, Artem Bityutskiy wrote: > > On Fri, 2009-08-07 at 23:43 -0600, Grant Likely wrote: > > > On Fri, Jul 17, 2009 at 6:39 AM, Wolfram Sang wrote: > > > > Use physmap_of to access RAMs as mtd and add documenation for it. This approach > > > > is a lot less intrusive as adding an of-wrapper around plat-ram.c. As most > > > > extensions of plat-ram.c (e.g. custom map-functions) can't be mapped to the > > > > device tree anyhow, extending physmap_of seems to be the cleanest approach. > > > > > > > > Tested with a phyCORE-MPC5121e. > > > > > > > > Signed-off-by: Wolfram Sang > > > > > > Looks good to me. > > > > > > Acked-by: Grant Likely > > > > This patch is sitting in my l2-mtd-2.6.git tree. > > Great, thanks a lot (and for your l2-tree in general!). One question: Are the > additional Acked-bys added later? I could think they might be useful for > David's review... Well, I do not bother maintaining nice history there, so rebase it freely, which means I can add your ack. Will do tomorrow. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 6A984B6F31 for ; Tue, 11 Aug 2009 02:28:05 +1000 (EST) Subject: Re: [PATCH] mtd/maps: add mtd-ram support to physmap_of From: Artem Bityutskiy To: Wolfram Sang In-Reply-To: <20090810161942.GA27833@pengutronix.de> References: <1247834363-28198-1-git-send-email-w.sang@pengutronix.de> <1249795043.9157.37.camel@localhost> <20090810161942.GA27833@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Date: Mon, 10 Aug 2009 19:25:56 +0300 Message-Id: <1249921556.19638.16.camel@localhost> Mime-Version: 1.0 Cc: devicetree-discuss@ozlabs.org, Vitaly Wool , Albrecht =?ISO-8859-1?Q?Dre=DF?= , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, Ken MacLeod , David Woodhouse Reply-To: dedekind@infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2009-08-10 at 18:19 +0200, Wolfram Sang wrote: > On Sun, Aug 09, 2009 at 08:17:23AM +0300, Artem Bityutskiy wrote: > > On Fri, 2009-08-07 at 23:43 -0600, Grant Likely wrote: > > > On Fri, Jul 17, 2009 at 6:39 AM, Wolfram Sang wrote: > > > > Use physmap_of to access RAMs as mtd and add documenation for it. This approach > > > > is a lot less intrusive as adding an of-wrapper around plat-ram.c. As most > > > > extensions of plat-ram.c (e.g. custom map-functions) can't be mapped to the > > > > device tree anyhow, extending physmap_of seems to be the cleanest approach. > > > > > > > > Tested with a phyCORE-MPC5121e. > > > > > > > > Signed-off-by: Wolfram Sang > > > > > > Looks good to me. > > > > > > Acked-by: Grant Likely > > > > This patch is sitting in my l2-mtd-2.6.git tree. > > Great, thanks a lot (and for your l2-tree in general!). One question: Are the > additional Acked-bys added later? I could think they might be useful for > David's review... Well, I do not bother maintaining nice history there, so rebase it freely, which means I can add your ack. Will do tomorrow. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH] mtd/maps: add mtd-ram support to physmap_of Date: Mon, 10 Aug 2009 19:25:56 +0300 Message-ID: <1249921556.19638.16.camel@localhost> References: <1247834363-28198-1-git-send-email-w.sang@pengutronix.de> <1249795043.9157.37.camel@localhost> <20090810161942.GA27833@pengutronix.de> Reply-To: dedekind-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20090810161942.GA27833-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Wolfram Sang Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Vitaly Wool , Albrecht =?ISO-8859-1?Q?Dre=DF?= , linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Ken MacLeod , David Woodhouse List-Id: devicetree@vger.kernel.org T24gTW9uLCAyMDA5LTA4LTEwIGF0IDE4OjE5ICswMjAwLCBXb2xmcmFtIFNhbmcgd3JvdGU6Cj4g T24gU3VuLCBBdWcgMDksIDIwMDkgYXQgMDg6MTc6MjNBTSArMDMwMCwgQXJ0ZW0gQml0eXV0c2tp eSB3cm90ZToKPiA+IE9uIEZyaSwgMjAwOS0wOC0wNyBhdCAyMzo0MyAtMDYwMCwgR3JhbnQgTGlr ZWx5IHdyb3RlOgo+ID4gPiBPbiBGcmksIEp1bCAxNywgMjAwOSBhdCA2OjM5IEFNLCBXb2xmcmFt IFNhbmc8dy5zYW5nQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKPiA+ID4gPiBVc2UgcGh5c21hcF9v ZiB0byBhY2Nlc3MgUkFNcyBhcyBtdGQgYW5kIGFkZCBkb2N1bWVuYXRpb24gZm9yIGl0LiBUaGlz IGFwcHJvYWNoCj4gPiA+ID4gaXMgYSBsb3QgbGVzcyBpbnRydXNpdmUgYXMgYWRkaW5nIGFuIG9m LXdyYXBwZXIgYXJvdW5kIHBsYXQtcmFtLmMuIEFzIG1vc3QKPiA+ID4gPiBleHRlbnNpb25zIG9m IHBsYXQtcmFtLmMgKGUuZy4gY3VzdG9tIG1hcC1mdW5jdGlvbnMpIGNhbid0IGJlIG1hcHBlZCB0 byB0aGUKPiA+ID4gPiBkZXZpY2UgdHJlZSBhbnlob3csIGV4dGVuZGluZyBwaHlzbWFwX29mIHNl ZW1zIHRvIGJlIHRoZSBjbGVhbmVzdCBhcHByb2FjaC4KPiA+ID4gPgo+ID4gPiA+IFRlc3RlZCB3 aXRoIGEgcGh5Q09SRS1NUEM1MTIxZS4KPiA+ID4gPgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFdv bGZyYW0gU2FuZyA8dy5zYW5nQHBlbmd1dHJvbml4LmRlPgo+ID4gPiAKPiA+ID4gTG9va3MgZ29v ZCB0byBtZS4KPiA+ID4gCj4gPiA+IEFja2VkLWJ5OiBHcmFudCBMaWtlbHkgPGdyYW50Lmxpa2Vs eUBzZWNyZXRsYWIuY2E+Cj4gPiAKPiA+IFRoaXMgcGF0Y2ggaXMgc2l0dGluZyBpbiBteSBsMi1t dGQtMi42LmdpdCB0cmVlLgo+IAo+IEdyZWF0LCB0aGFua3MgYSBsb3QgKGFuZCBmb3IgeW91ciBs Mi10cmVlIGluIGdlbmVyYWwhKS4gT25lIHF1ZXN0aW9uOiBBcmUgdGhlCj4gYWRkaXRpb25hbCBB Y2tlZC1ieXMgYWRkZWQgbGF0ZXI/IEkgY291bGQgdGhpbmsgdGhleSBtaWdodCBiZSB1c2VmdWwg Zm9yCj4gRGF2aWQncyByZXZpZXcuLi4KCldlbGwsIEkgZG8gbm90IGJvdGhlciBtYWludGFpbmlu ZyBuaWNlIGhpc3RvcnkgdGhlcmUsIHNvIHJlYmFzZSBpdApmcmVlbHksIHdoaWNoIG1lYW5zIEkg Y2FuIGFkZCB5b3VyIGFjay4gV2lsbCBkbyB0b21vcnJvdy4KCi0tIApCZXN0IFJlZ2FyZHMsCkFy dGVtIEJpdHl1dHNraXkgKNCQ0YDRgtGR0Lwg0JHQuNGC0Y7RhtC60LjQuSkKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmljZXRyZWUtZGlzY3VzcyBt YWlsaW5nIGxpc3QKZGV2aWNldHJlZS1kaXNjdXNzQGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9s aXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2RldmljZXRyZWUtZGlzY3Vzcwo=