From: Johannes Berg <johannes@sipsolutions.net>
To: vibi_sreenivasan@cms.com
Cc: linux-next@vger.kernel.org, Thomas Graf <tgraf@suug.ch>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] Fix Warnings from net/netlink/genetlink.c
Date: Tue, 11 Aug 2009 11:11:16 +0200 [thread overview]
Message-ID: <1249981876.3015.0.camel@johannes.local> (raw)
In-Reply-To: <1249982110.13065.7.camel@HunTEr>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
Hi,
> > > net/netlink/genetlink.c: In function `genl_register_mc_group':
> > > net/netlink/genetlink.c:139: warning: 'err' might be used uninitialized in this function
> >
> > Well, only if there's no netns which can't happen.
> So how to silence that warning?
Well, I suppose your patch is the best way anyhow, using
uninitialized_var() would seem somewhat dangerous for future
modifications of the function.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-08-11 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1249975630.2400.7.camel@HunTEr>
2009-08-11 7:36 ` [PATCH] Fix Warnings from net/netlink/genetlink.c Johannes Berg
2009-08-11 9:15 ` vibi sreenivasan
2009-08-11 9:11 ` Johannes Berg [this message]
2009-08-11 10:07 vibi sreenivasan
2009-08-11 23:57 ` Marcel Holtmann
2009-08-12 3:24 ` Stephen Hemminger
2009-08-12 3:50 ` Stephen Rothwell
2009-08-12 4:03 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249981876.3015.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=vibi_sreenivasan@cms.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.