All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Lucas Meneghel Rodrigues <mrodrigu@redhat.com>
Cc: kvm@vger.kernel.org
Subject: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program
Date: Wed, 12 Aug 2009 12:34:45 +0300	[thread overview]
Message-ID: <1250069685-17727-3-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1250069685-17727-1-git-send-email-avi@redhat.com>

This is faster since we don't need to fork/exec/wait for an external
program each time.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 client/tests/kvm/kvm_guest_wizard.py |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/tests/kvm/kvm_guest_wizard.py b/client/tests/kvm/kvm_guest_wizard.py
index 73b830e..f9e5476 100644
--- a/client/tests/kvm/kvm_guest_wizard.py
+++ b/client/tests/kvm/kvm_guest_wizard.py
@@ -1,6 +1,7 @@
 import os, time, md5, re, shutil, logging
 from autotest_lib.client.common_lib import utils, error
 import kvm_utils, ppm_utils, kvm_subprocess
+import PIL.Image
 
 """
 Utilities to perform automatic guest installation using step files.
@@ -110,9 +111,8 @@ def barrier_2(vm, words, params, debug_dir, data_scrdump_filename,
             history_scrdump_filename = os.path.join(history_dir,
                     "scrdump-step_%s-%s.jpg" % (current_step_num,
                                                 time.strftime("%Y%m%d-%H%M%S")))
-            kvm_subprocess.run_fg("convert -quality 30 %s %s" %
-                                  (scrdump_filename, history_scrdump_filename),
-                                  logging.debug, "(convert) ", timeout=30)
+            image = PIL.Image.open(scrdump_filename)
+            image.save(history_scrdump_filename, format = 'JPEG', quality = 30)
 
         # Compare md5sum of barrier region with the expected md5sum
         calced_md5sum = ppm_utils.get_region_md5sum(w, h, data, x1, y1, dx, dy,
-- 
1.6.3.3


  parent reply	other threads:[~2009-08-12  9:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12  9:34 [PATCH KVM-AUTOTEST 0/2] Remove some external command callouts Avi Kivity
2009-08-12  9:34 ` [PATCH KVM-AUTOTEST 1/2] Replace subprocess 'rm *.ppm' by equivalent Python code Avi Kivity
2009-08-12  9:34 ` Avi Kivity [this message]
2009-08-12 12:44   ` [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program Lucas Meneghel Rodrigues
2009-08-12 13:00     ` Avi Kivity
2009-08-12 13:26       ` Lucas Meneghel Rodrigues
2009-08-12 13:33         ` Avi Kivity
2009-08-12 15:01           ` Lucas Meneghel Rodrigues
2009-08-12 15:05             ` Avi Kivity
     [not found] <1587932675.1809681250071942865.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-12 10:13 ` Michael Goldish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250069685-17727-3-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mrodrigu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.