From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program Date: Wed, 12 Aug 2009 12:01:48 -0300 Message-ID: <1250089308.2921.55.camel@localhost.localdomain> References: <1250069685-17727-1-git-send-email-avi@redhat.com> <1250069685-17727-3-git-send-email-avi@redhat.com> <1250081076.2921.2.camel@localhost.localdomain> <4A82BCE6.9050703@redhat.com> <1250083579.2921.36.camel@localhost.localdomain> <4A82C4C0.1040605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Lucas Meneghel Rodrigues , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59961 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753382AbZHLPBw (ORCPT ); Wed, 12 Aug 2009 11:01:52 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7CF1rZr014334 for ; Wed, 12 Aug 2009 11:01:53 -0400 In-Reply-To: <4A82C4C0.1040605@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2009-08-12 at 16:33 +0300, Avi Kivity wrote: > On 08/12/2009 04:26 PM, Lucas Meneghel Rodrigues wrote: > > But I prefer to follow the project policy when possible. The reason why > > I accepted the original code that Michael wrote to perform the > > conversion was graceful degradation of functionality (if you don't have > > ImageMagick installed, the test will not abort). > > > > Well, policy is policy. See the attached (untested). Ok Avi, I've spotted other places where we are also making unneeded calls to rm and mogrify, so I changed them, combined the patches, changed the exception trap only to catch the exceptions we are waiting for, and send the patch to the mailing list. Please let me know what you think. Lucas