From: Maxim Levitsky <maximlevitsky@gmail.com>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Takashi Iwai <tiwai@suse.de>
Subject: [RFC] Break up the patch_sigmatel.c
Date: Wed, 12 Aug 2009 23:35:45 +0300 [thread overview]
Message-ID: <1250109345.7974.10.camel@localhost.localdomain> (raw)
Hi folks,
I own an stac9227 and with latest kernel, it doesn't output any sound
via front headphones. (this a is desktop)
I don't want to bother you with details, etc, I will fix that myself. I
have good knowledge of the device.
However, the mess that is patch_sigmatel.c seems to be doubled.
its huge file, and there are loads on new codecs added.
I have a suggestion, to break it up into smaller files.
I especially want to move all 'data' from it to header file, and sort it
by model.
Maybe move pin configs to separate file.
Also I know that stac9200 is quite old, and uses many different support
functions. I could move these in another file as well.
In other words, I want to break it up into several (5 maybe) files,
while not touching the code itself (I so that later maybe)
Since it is quite dirty and hard work, I want to ask if you agree.
Btw, half of static data can be retrieved from codec by querying it
(like dac,adc,pin node ids)
Best regards,
Maxim Levitsky
next reply other threads:[~2009-08-12 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 20:35 Maxim Levitsky [this message]
2009-08-12 20:45 ` [RFC] Break up the patch_sigmatel.c Daniel Chen
2009-08-12 20:50 ` Maxim Levitsky
2009-08-13 5:28 ` Takashi Iwai
2009-08-13 7:34 ` Maxim Levitsky
2009-08-13 7:55 ` Takashi Iwai
2009-08-13 15:05 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250109345.7974.10.camel@localhost.localdomain \
--to=maximlevitsky@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.