From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MbSTn-0002U7-QU for mharc-grub-devel@gnu.org; Thu, 13 Aug 2009 01:03:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbSTm-0002T9-Bq for grub-devel@gnu.org; Thu, 13 Aug 2009 01:03:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbSTh-0002S3-KG for grub-devel@gnu.org; Thu, 13 Aug 2009 01:03:57 -0400 Received: from [199.232.76.173] (port=34703 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbSTh-0002S0-Dg for grub-devel@gnu.org; Thu, 13 Aug 2009 01:03:53 -0400 Received: from c60.cesmail.net ([216.154.195.49]:1316) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MbSTg-0001Ln-9a for grub-devel@gnu.org; Thu, 13 Aug 2009 01:03:52 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 13 Aug 2009 01:03:48 -0400 Received: from [192.168.1.151] (c-69-141-194-35.hsd1.pa.comcast.net [69.141.194.35]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 8B40A34C6D for ; Thu, 13 Aug 2009 01:17:31 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <1245115723.27324.34.camel@mj> Content-Type: text/plain Date: Thu, 13 Aug 2009 01:03:34 -0400 Message-Id: <1250139814.2352.3.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH 6/18] define asm constant for absolute memory access X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 05:03:58 -0000 On Tue, 2009-06-16 at 12:49 +0200, Vladimir 'phcoder' Serbinenko wrote: > > +#ifdef APPLE_CC > > + movl $(mmaphook_mmap_rel), %esi > > +#else > > movw $(DS(mmaphook_mmap)), %si > > +#endif > > That's not an equivalent replacement. The argument width is > different. > I know. Sometimes because of the quirks I had to replace some code > with a less logical alternative which should however work in the flow Please don't commit such changes without an explicit permissions form the maintainers. It's very time consuming to verify such code after it has been committed. -- Regards, Pavel Roskin