From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MbSko-0000QG-Vn for mharc-grub-devel@gnu.org; Thu, 13 Aug 2009 01:21:35 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbSkm-0000Pa-PK for grub-devel@gnu.org; Thu, 13 Aug 2009 01:21:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbSkh-0000No-OJ for grub-devel@gnu.org; Thu, 13 Aug 2009 01:21:32 -0400 Received: from [199.232.76.173] (port=38610 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbSkh-0000Nl-99 for grub-devel@gnu.org; Thu, 13 Aug 2009 01:21:27 -0400 Received: from c60.cesmail.net ([216.154.195.49]:59051) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MbSkg-0003az-G5 for grub-devel@gnu.org; Thu, 13 Aug 2009 01:21:26 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 13 Aug 2009 01:21:25 -0400 Received: from [192.168.1.151] (c-69-141-194-35.hsd1.pa.comcast.net [69.141.194.35]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 357AB34C6D for ; Thu, 13 Aug 2009 01:35:08 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20090716034703.29978.94862.stgit@ct.roinet.com> Content-Type: text/plain Date: Thu, 13 Aug 2009 01:21:13 -0400 Message-Id: <1250140873.2352.20.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH 1/2] RFT: Eliminate Apple specific code from boot/i386/pc/boot.S X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 05:21:33 -0000 On Thu, 2009-07-16 at 18:31 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Jul 16, 2009 at 5:47 AM, Pavel Roskin wrote: > > ChangeLog: > > > > * boot/i386/pc/boot.S: Remove all code dependent on APPLE_CC. > > Use local labels starting with "L_" so that Apple assembler > > would know they are local. > You have really a lot of patches. I don't think so. > It's undoubtly a good thing but > since I was on vacation I lost a track a bit. For casual viewers I > suppose it's even worse. Perhaps you could create a git repository > which would hold all patches you haven't committed yet, one per > branch? I'm sorry, I don't have time to create any private repositories. I wish I could do it, but I couldn't find time from that for almost a month, so chances are it won't happen any time soon. > It will make a much better overview. Bean created a mirror on > github. Perhaps we can use it as a tool to have an easily-viewable > list of all unmerged patches and prevent patches from get lost. I know > it's really unfortunate that I come up with a proposition of using > such system for a relatively small project like grub. Alternatively we > may want to formulate rules which would prevent future developpement > deadlocks. There are ways to apply patches from e-mail. STGit can do it. My concern is that we would make the submitters responsible for something other than the quality of the patch if we require them to create private repositories. Normally, a patch is good as long as it applies. With a private repository, it will need to be kept up-to-date with the master repository, otherwise testing might find already fixed problems. As for the deadlocks, I don't think it's a technical issue. In any case, I find myself submitting too many patches, I'm ready to reconsider, but right now I cannot create any private repositories. -- Regards, Pavel Roskin