From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MbTZU-00011k-4d for mharc-grub-devel@gnu.org; Thu, 13 Aug 2009 02:13:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbTZQ-0000z6-Ct for grub-devel@gnu.org; Thu, 13 Aug 2009 02:13:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbTZL-0000vr-KD for grub-devel@gnu.org; Thu, 13 Aug 2009 02:13:51 -0400 Received: from [199.232.76.173] (port=54942 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbTZL-0000vY-BM for grub-devel@gnu.org; Thu, 13 Aug 2009 02:13:47 -0400 Received: from c60.cesmail.net ([216.154.195.49]:44373) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MbTZK-0003FE-M5 for grub-devel@gnu.org; Thu, 13 Aug 2009 02:13:46 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 13 Aug 2009 02:13:45 -0400 Received: from [192.168.1.151] (c-69-141-194-35.hsd1.pa.comcast.net [69.141.194.35]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id C1B5334C6D for ; Thu, 13 Aug 2009 02:27:27 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090810112941.GB9344@thorin> References: <20090716034703.29978.94862.stgit@ct.roinet.com> <0EAFAFCD-18DB-46F1-905D-30AF8B743D13@zetam.org> <20090810112941.GB9344@thorin> Content-Type: text/plain Date: Thu, 13 Aug 2009 02:13:32 -0400 Message-Id: <1250144012.2352.35.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] RFT: Rename local labels with a macro from boot/i386/pc/boot.S X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 06:13:52 -0000 On Mon, 2009-08-10 at 13:29 +0200, Robert Millan wrote: > On Sat, Aug 08, 2009 at 04:48:32PM +0200, Yves Blusseau wrote: > > diff --git a/include/grub/symbol.h b/include/grub/symbol.h > > index 68d9f00..5fba549 100644 > > --- a/include/grub/symbol.h > > +++ b/include/grub/symbol.h > > @@ -21,6 +21,8 @@ > > > > #include > > > > +#define LOCAL(X) L_##X > > + > > /* Add an underscore to a C symbol in assembler code if needed. */ > > #ifdef HAVE_ASM_USCORE > > # define EXT_C(sym) _ ## sym I changed LOCAL to be more similar to EXT_C (macro arguments don't normally use capital letters). I also added a comment, as there is no other way to know why we are adding "L_" to the labels. > Assuming Pavel is OK with it, I have no objection. Committed. Thank you! -- Regards, Pavel Roskin