From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>,
stephane eranian <eranian@googlemail.com>,
Corey J Ashford <cjashfor@us.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/2] perf tools: Fixup read ABI breakage
Date: Thu, 13 Aug 2009 09:51:53 +0200 [thread overview]
Message-ID: <1250149914.10001.65.camel@twins> (raw)
In-Reply-To: <20090812153529.716542680@chello.nl>
Subject: perf tools: Fixup read ABI breakage
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Thu Aug 13 09:03:33 CEST 2009
Update the perf tool to the new read output format.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
tools/perf/builtin-record.c | 2 +-
tools/perf/builtin-stat.c | 8 +++++---
tools/perf/util/event.h | 10 ++++++++--
3 files changed, 14 insertions(+), 6 deletions(-)
Index: linux-2.6/tools/perf/builtin-record.c
===================================================================
--- linux-2.6.orig/tools/perf/builtin-record.c
+++ linux-2.6/tools/perf/builtin-record.c
@@ -370,9 +370,9 @@ static void create_counter(int counter,
struct perf_header_attr *h_attr;
int track = !counter; /* only the first counter needs these */
struct {
- u64 count;
u64 time_enabled;
u64 time_running;
+ u64 count;
u64 id;
} read_data;
Index: linux-2.6/tools/perf/builtin-stat.c
===================================================================
--- linux-2.6.orig/tools/perf/builtin-stat.c
+++ linux-2.6/tools/perf/builtin-stat.c
@@ -168,10 +168,12 @@ static void read_counter(int counter)
close(fd[cpu][counter]);
fd[cpu][counter] = -1;
- count[0] += single_count[0];
if (scale) {
- count[1] += single_count[1];
- count[2] += single_count[2];
+ count[0] += single_count[2]; /* value */
+ count[1] += single_count[0]; /* enabled */
+ count[2] += single_count[1]; /* running */
+ } else {
+ count[0] += single_count[0]; /* value */
}
}
Index: linux-2.6/tools/perf/util/event.h
===================================================================
--- linux-2.6.orig/tools/perf/util/event.h
+++ linux-2.6/tools/perf/util/event.h
@@ -4,6 +4,9 @@
#include "util.h"
#include <linux/list.h>
+/*
+ * PERF_SAMPLE_IP | PERF_SAMPLE_TID | *
+ */
struct ip_event {
struct perf_event_header header;
u64 ip;
@@ -38,12 +41,15 @@ struct lost_event {
u64 lost;
};
-struct read_event {
+/*
+ * PERF_FORMAT_ENABLED | PERF_FORMAT_RUNNING | PERF_FORMAT_ID
+ */
+struct read_event {
struct perf_event_header header;
u32 pid,tid;
- u64 value;
u64 time_enabled;
u64 time_running;
+ u64 value;
u64 id;
};
next prev parent reply other threads:[~2009-08-13 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 15:35 [PATCH 0/2] perf_counter: fix the group mess Peter Zijlstra
2009-08-12 15:35 ` [PATCH 1/2] perf: rework the whole read vs group stuff Peter Zijlstra
2009-08-12 15:35 ` [PATCH 2/2] perf_counter: Fix an ipi-deadlock Peter Zijlstra
2009-08-12 15:54 ` [PATCH 0/2] perf_counter: fix the group mess stephane eranian
2009-08-12 16:01 ` Peter Zijlstra
2009-08-13 7:51 ` Peter Zijlstra [this message]
2009-08-13 7:51 ` [PATCH 4/2] perf_counter: Fix swcounter context invariance Peter Zijlstra
2009-08-13 8:05 ` Frederic Weisbecker
2009-08-13 8:22 ` Peter Zijlstra
2009-08-13 8:29 ` Frederic Weisbecker
2009-08-13 10:21 ` [tip:perfcounters/urgent] " tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250149914.10001.65.camel@twins \
--to=peterz@infradead.org \
--cc=cjashfor@us.ibm.com \
--cc=eranian@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.