All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Ribeiro <drwyrm@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Paul Shen <boshen9@gmail.com>,
	alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
	Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH 2/3] ASoC: pxa-ssp.c, Automatically set TDM when needed
Date: Sat, 15 Aug 2009 08:48:17 -0300	[thread overview]
Message-ID: <1250336897.18028.304.camel@brutus> (raw)
In-Reply-To: <20090815095120.GA29987@sirena.org.uk>


[-- Attachment #1.1: Type: text/plain, Size: 1273 bytes --]

Em Sáb, 2009-08-15 às 10:51 +0100, Mark Brown escreveu:
> On Fri, Aug 14, 2009 at 01:17:41PM -0300, Daniel Ribeiro wrote:
> 
> > This should be able to deal with I2S when pxa is slave, on both pxa2xx
> > and pxa3xx, with set_tdm_slot(5, 5, 4, 16).
> 
> > Or when pxa is master, on pxa3xx only, with set_tdm_slot(3, 3, 2, 16).
> > This still violates the "DMYSTOP must be clear on network mode" rule,
> > but as all slots are active its not really network mode. And it seems to
> > work for you, so... ;)
> 
> This seems really confusing from a usability point of view - the master
> and slave configurations should look the same.  I'd expec the slave mode
> configuration you quote above to be looking for twice as many clocks as
> the master mode one.  The driver should ideally encapsulate this.

Yes, this is really confusing. The hardware is weird and behaves
different when it is driving SFRM.

On both (slave/master) modes it will use the same clk cycles, its just
that on master half the clocks are skipped by DMYSTOP.

Maybe Daniel Mack can test a setup with PXA slave of SFRM, and if it
works for him, we can drop the pxa3xx-only I2S/master mode for now. It
is a mess and I don't see an easy way to solve this. :(

-- 
Daniel Ribeiro

[-- Attachment #1.2: Esta é uma parte de mensagem assinada digitalmente --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2009-08-15 11:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 14:55 [PATCH 1/3] ASoC: change set_tdm_slot api to allow slot_width override Mark Brown
2009-08-06 14:55 ` [PATCH 2/3] ASoC: pxa-ssp.c, Automatically set TDM when needed Mark Brown
2009-08-12 18:17   ` Daniel Mack
2009-08-14 16:17     ` Daniel Ribeiro
2009-08-15  9:51       ` Mark Brown
2009-08-15 11:48         ` Daniel Ribeiro [this message]
2009-08-17 15:35       ` Daniel Mack
2009-08-17 16:08         ` Mark Brown
2009-08-17 18:09         ` Daniel Ribeiro
2009-08-13  1:28   ` Daniel Mack
2009-08-06 14:55 ` [PATCH 3/3] ASoC: pxa-ssp.c handle the I2S and LEFT_J cases Mark Brown
2009-08-06 14:59 ` [PATCH 1/3] ASoC: change set_tdm_slot api to allow slot_width override Daniel Mack
2009-08-11 12:04 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2009-06-16  0:44 [PATCH 2/3] ASoC: pxa-ssp.c, Automatically set TDM when needed Daniel Ribeiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250336897.18028.304.camel@brutus \
    --to=drwyrm@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=boshen9@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=eric.y.miao@gmail.com \
    --cc=philipp.zabel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.