From: Shine Liu <shinel@foxmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: UDA134X Codec: Fix mute/unmute code mistake and add ADC/DAC power control support
Date: Mon, 17 Aug 2009 19:53:15 +0800 [thread overview]
Message-ID: <1250509995.1932.44.camel@shinel> (raw)
In-Reply-To: <20090817112756.GA19898@rakim.wolfsonmicro.main>
On Mon, 2009-08-17 at 12:27 +0100, Mark Brown wrote:
> + /* If there are no DAPM widgets then try to figure out power from the
> + * event type.
> + */
> + if (list_empty(&codec->dapm_widgets)) {
> + switch (event) {
> + case SND_SOC_DAPM_STREAM_START:
> + case SND_SOC_DAPM_STREAM_RESUME:
> + sys_power = 1;
> + break;
> + case SND_SOC_DAPM_STREAM_NOP:
> + sys_power == codec->bias_level != SND_SOC_BIAS_STANDBY;
Should be "sys_power = codec->bias_level != SND_SOC_BIAS_STANDBY;" ?
> + default:
> + break;
> + }
> + }
> +
> /* If we're changing to all on or all off then prepare */
> if ((sys_power && codec->bias_level == SND_SOC_BIAS_STANDBY) ||
> (!sys_power && codec->bias_level == SND_SOC_BIAS_ON)) {
>
>
>
next prev parent reply other threads:[~2009-08-17 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 8:36 [PATCH] ASoC: UDA134X Codec: Fix mute/unmute code mistake and add ADC/DAC power control support Shine Liu
2009-08-17 10:32 ` Mark Brown
2009-08-17 10:52 ` [PATCH] ASoC: UDA134X: Fix mistaken mute/unmute code Shine Liu
2009-08-17 10:59 ` Mark Brown
2009-08-17 11:22 ` [PATCH] ASoC: UDA134X Codec: Fix mute/unmute code mistake and add ADC/DAC power control support Shine Liu
2009-08-17 11:27 ` Mark Brown
2009-08-17 11:53 ` Shine Liu [this message]
2009-08-17 11:56 ` Mark Brown
2009-08-17 11:43 ` [PATCH] ASoC: UDA134X: Fix mistaken mute/unmute code Shine Liu
-- strict thread matches above, loose matches on Subject: below --
2009-08-17 6:57 [PATCH] ASoC: UDA134X Codec: Fix mute/unmute code mistake and add ADC/DAC power control support Shine Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250509995.1932.44.camel@shinel \
--to=shinel@foxmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.