From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mjzwl-00064o-G2 for mharc-grub-devel@gnu.org; Sat, 05 Sep 2009 14:25:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mjzwj-00062T-4f for grub-devel@gnu.org; Sat, 05 Sep 2009 14:25:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mjzwe-0005tB-59 for grub-devel@gnu.org; Sat, 05 Sep 2009 14:25:08 -0400 Received: from [199.232.76.173] (port=52476 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mjzwd-0005t8-Vp for grub-devel@gnu.org; Sat, 05 Sep 2009 14:25:04 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:57626) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mjzwd-0005Uq-Fe for grub-devel@gnu.org; Sat, 05 Sep 2009 14:25:03 -0400 Received: from [85.180.18.78] (e180018078.adsl.alicedsl.de [85.180.18.78]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1Mjzwc0ooH-0003zI; Sat, 05 Sep 2009 20:25:02 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090904192657.GA4059@thorin> References: <1252090364.2888.12.camel@fz.local> <20090904192657.GA4059@thorin> Content-Type: text/plain Date: Sat, 05 Sep 2009 20:25:01 +0200 Message-Id: <1252175101.6437.23.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.91 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX19CTxgURrAH/s6L3xqzV+0ATGoKK+6ievCCmhP R+B8qG+JJ8Gtro9NxIPEbgtDvZQqmNGpsvLDmttRQdKeCHFXLI 8/UPxX6R1olcvPYuTnvZw== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: r2558 made another use case for make_relative_to_its_root visible (else SEGFAULT) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Sep 2009 18:25:09 -0000 Am Freitag, den 04.09.2009, 21:26 +0200 schrieb Robert Millan: > On Fri, Sep 04, 2009 at 08:52:44PM +0200, Felix Zielcke wrote: > > r2558 actually enabled this code path which was (almost) never executed > > before in probe(): > > > > if (S_ISREG (st.st_mode)) > > { > > /* Regular file. Verify that we can read it properly. */ > > > > grub_file_t file; > > grub_util_info ("reading %s via OS facilities", path); > > filebuf_via_sys = grub_util_read_image (path); > > > > grub_util_info ("reading %s via GRUB facilities", path); > > asprintf (&grub_path, "(%s)%s", drive_name, path); > > file = grub_file_open (grub_path); > > filebuf_via_grub = xmalloc (file->size); > > grub_file_read (file, filebuf_via_grub, file->size); > > > > grub_util_info ("comparing"); > > > > if (memcmp (filebuf_via_grub, filebuf_via_sys, file->size)) > > grub_util_error ("files differ"); > > } > > printf ("%s\n", fs->name); > > > > If /boot is on a seperate partition and you run `grub-probe -t > > fs /boot/grub/core.img' grub_file_open returns 0 because grub_path is > > the full system path and not a relative path which GRUB needs. > > A proper fix for this would be too intrusive for 1.97. Unless someone > has a bright idea, I'll comment it out untill we've released. For the release this is probable the best idea. -- Felix Zielcke Proud Debian Maintainer