From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MkI29-00046L-38 for mharc-grub-devel@gnu.org; Sun, 06 Sep 2009 09:43:57 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MkI27-000469-Lt for grub-devel@gnu.org; Sun, 06 Sep 2009 09:43:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MkI23-00045Z-31 for grub-devel@gnu.org; Sun, 06 Sep 2009 09:43:55 -0400 Received: from [199.232.76.173] (port=58868 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MkI22-00045P-S0 for grub-devel@gnu.org; Sun, 06 Sep 2009 09:43:50 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:57970) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MkI22-0004np-5P for grub-devel@gnu.org; Sun, 06 Sep 2009 09:43:50 -0400 Received: from [85.180.47.88] (e180047088.adsl.alicedsl.de [85.180.47.88]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1MkI1z2B9b-0003nw; Sun, 06 Sep 2009 15:43:48 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090906133818.GI13423@riva.ucam.org> References: <1252240143.3895.18.camel@fz.local> <20090906133818.GI13423@riva.ucam.org> Content-Type: text/plain Date: Sun, 06 Sep 2009 15:43:46 +0200 Message-Id: <1252244626.3895.52.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.91 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/J9hgtPKz8PK6q7CNYEYHQPQDZQ9b65IUmHcv vz4d+9RcmgM3aJsCFoXUyo/Iuvt2ny9swPa/4+2EIFR7b5C+XU NhZvGNZg5Pggg/kLb9S3A== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: chmod of generated grub.cfg X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Sep 2009 13:43:56 -0000 Am Sonntag, den 06.09.2009, 14:38 +0100 schrieb Colin Watson: > On Sun, Sep 06, 2009 at 02:29:03PM +0200, Felix Zielcke wrote: > > Currently grub-mkconfig uses chmod 444 on the newly generated grub.cfg > > Wouldn't it be better to use 400 now that we have plaintext password > > support? > > Or should we add support for a GRUB_CHMOD variable so users can override > > this setting as they please? > > I'd prefer to see this done only if they set a password. A GRUB_CHMOD > variable seems overkill, though. > > Else I'd need to add a /etc/grub.d/999_chmod file in grub-installer > > which changes the mode of grub.cfg.new if the user wants to have a > > password. > > I think it'd be more sensible to do this in grub-mkconfig itself - it > doesn't really fit well into the /etc/grub.d/ hook system, which is > really just for generating output. You mean we check with grep if there's a password line in the generated config and then just use chmod 400 instead of 444? Sounds good. -- Felix Zielcke Proud Debian Maintainer